Paths

Table of Contentst

Differential D25682

Fix a leftover misspelled "Phabricator" reference
ClosedPublic
Actions

Authored by pppery on Jun 6 2024, 02:27.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15850: Typo in auth message when unlinking accounts

Commits

rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference

Summary

Closes T15850

Test Plan

Read the code and see that there isn't a typo anymore

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pppery created this revision.Jun 6 2024, 02:27

Owners added a reviewer: O1: Blessed Committers.Jun 6 2024, 02:27

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 6 2024, 02:27

pppery requested review of this revision.Jun 6 2024, 02:27

Harbormaster completed remote builds in B1330: Diff 2086.Jun 6 2024, 02:27

I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.

There may be some room for extra clarity for users in complex organization setups, but this is a rare enough operation (outside of dev) that it's probably not worth worrying about.

This revision is now accepted and ready to land.Jun 6 2024, 06:51

Closed by commit rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference. · Explain WhyJun 6 2024, 14:37

This revision was automatically updated to reflect the committed changes.

pppery added a commit: rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

controller/

PhabricatorAuthUnlinkController.php

2 lines

O1: Blessed Committers

Diff 2088

src/applications/auth/controller/PhabricatorAuthUnlinkController.php

Loading...