Paths

Table of Contentst

Differential D25652

Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine
ClosedPublic
Actions

Authored by aklapper on May 16 2024, 15:29.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Commits

rARC21fbc806e4e1: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in…

Summary

ArcanistAliasEffect::EFFECT_CONFIGURATION does not exist.
Probably ArcanistAliasEffect::EFFECT_MISCONFIGURATION was meant, given the message it sets.

Test Plan

Carefully read the code.

Diff Detail

Repository

rARC Arcanist

Branch

undefinedAliasEffect (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1274
Build 1274: arc lint + arc unit

Event Timeline

aklapper created this revision.May 16 2024, 15:29

Owners added a reviewer: O1: Blessed Committers.May 16 2024, 15:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 16 2024, 15:29

aklapper requested review of this revision.May 16 2024, 15:29

Harbormaster completed remote builds in B1274: Diff 2004.May 16 2024, 15:29

avivey accepted this revision.Jun 23 2024, 07:31

This revision is now accepted and ready to land.Jun 23 2024, 07:31

Closed by commit rARC21fbc806e4e1: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in…. · Explain WhyJun 23 2024, 08:03

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC21fbc806e4e1: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in….

Revision Contents
Changeset List

Path

Size

Packages

src/

toolset/

ArcanistAliasEngine.php

3 lines

O1: Blessed Committers

Diff 2004

View Options

src/toolset/ArcanistAliasEngine.php

Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngineClosedPublicActions