Differential D25635
Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php Authored by aklapper on May 11 2024, 20:51. Tags None Referenced Files
Details
Passing null to preg_replace() is deprecated behavior since PHP 8.1. ERROR 8192: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283] Closes T15824 Unclear.
Diff Detail
Event TimelineComment Actions Uhm, seems I was somehow off by one line. I thought that this comes from escapeToken($repository->getCallsign()) being optional nowadays but seems to be triggered by escapeToken($repository->getRepositorySlug()) instead which indeed would be surprising. This might be a patch to abandon because might hide an underlying issue. Comment Actions revi confirmed this is called by getRepositorySlug() so abandoning this patch as hiding the underlying issue (no repository slug defined?) is not the right approach |