Differential D25614
Explicitly cast "limit" (page size) API parameter to int Authored by aklapper on May 3 2024, 16:03.
Details
Do not throw an exception when the limit (page size) Conduit API parameter is a float but explicitly convert to int. ERROR 8192: Implicit conversion from float to int loses precision at [/var/www/html/phorge/phorge/src/view/control/AphrontCursorPagerView.php:76] Closes T15810 Call /conduit/method/maniphest.search/ with a float value for the limit field. Check the server logs or DarkConsole.
Diff Detail
Event TimelineComment Actions Thanks!
Comment Actions Should the conduit handler also check this and throw an exception? Doing so will send back a more informative error to the caller. I did some of this in https://secure.phabricator.com/D21872 Comment Actions I guess that would imply editing 15-20 *ConduitAPIMethod.php files which currently $limit = $request->getValue('limit');
if (!$limit) {
$limit = $this->getDefaultLimit();
}and add something like if (!is_int($limit) && !ctype_digit($limit)) {
throw new Exception(pht('Field "limit" must be an integer value.'));
}? Hmm. | ||||||||||||||||||
