Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:29.
Tags
None
Referenced Files
F2198319: D25582.1716338303.diff
Tue, May 21, 00:38
F2198112: D25582.1716316182.diff
Mon, May 20, 18:29
Unknown Object (File)
Wed, May 8, 00:49
Unknown Object (File)
Tue, May 7, 20:26
Unknown Object (File)
Tue, May 7, 10:57
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 23:30

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php:30]
Test Plan

Run ../phorge/bin/auth unlimit: Get no strlen() error anymore but only expected output Usage Exception: Use --user to choose a user to reset actions for.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable