Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:29.
Tags
None
Referenced Files
F3318004: D25582.1743271549.diff
Fri, Mar 28, 18:05
F3316516: D25582.1743251487.diff
Fri, Mar 28, 12:31
F3309885: D25582.1743189451.diff
Thu, Mar 27, 19:17
F3307653: D25582.1743149634.diff
Thu, Mar 27, 08:13
F3306994: D25582.1743135520.diff
Thu, Mar 27, 04:18
F3283724: D25582.1742758840.diff
Sat, Mar 22, 19:40
F3249436: D25582.1742286107.diff
Mon, Mar 17, 08:21
F3246233: D25582.1742203748.diff
Sun, Mar 16, 09:29

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php:30]
Test Plan

Run ../phorge/bin/auth unlimit: Get no strlen() error anymore but only expected output Usage Exception: Use --user to choose a user to reset actions for.

Diff Detail

Repository
rP Phorge
Branch
cliAuthUnlimitStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1174
Build 1174: arc lint + arc unit