Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:23.
Tags
None
Referenced Files
F3108133: D25580.1741130709.diff
Mon, Mar 3, 23:25
F3108129: D25580.1741130706.diff
Mon, Mar 3, 23:25
F3108010: D25580.1741130366.diff
Mon, Mar 3, 23:19
F3046437: D25580.1740969966.diff
Sun, Mar 2, 02:46
F3005610: D25580.1740532489.diff
Tue, Feb 25, 01:14
F2996387: D25580.1740373823.diff
Sun, Feb 23, 05:10
F2995349: D25580.1740337345.diff
Sat, Feb 22, 19:02
F2995325: D25580.1740336129.diff
Sat, Feb 22, 18:42

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/nuance/management/NuanceManagementWorkflow.php:8]
Test Plan

Run ../phorge/bin/nuance import: Get no strlen() error anymore but only expected output Usage Exception: Specify a source with --source.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable