Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:23.
Tags
None
Referenced Files
F3325387: D25580.1743414857.diff
Sun, Mar 30, 09:54
F3319935: D25580.1743318283.diff
Sat, Mar 29, 07:04
F3309650: D25580.1743187113.diff
Thu, Mar 27, 18:38
F3298959: D25580.1743013440.diff
Tue, Mar 25, 18:24
F3295918: D25580.1742964104.diff
Tue, Mar 25, 04:41
F3291759: D25580.1742880828.diff
Mon, Mar 24, 05:33
F3291746: D25580.1742880587.diff
Mon, Mar 24, 05:29
F3283482: D25580.1742751465.diff
Sat, Mar 22, 17:37

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/nuance/management/NuanceManagementWorkflow.php:8]
Test Plan

Run ../phorge/bin/nuance import: Get no strlen() error anymore but only expected output Usage Exception: Specify a source with --source.

Diff Detail

Repository
rP Phorge
Branch
cliNuanceSourceStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1172
Build 1172: arc lint + arc unit