Page MenuHomePhorge

Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField
ClosedPublic

Authored by aklapper on Jan 26 2024, 11:01.
Tags
None
Referenced Files
F2186879: D25527.diff
Fri, May 10, 17:16
Unknown Object (File)
Tue, May 7, 17:30
Unknown Object (File)
Sat, May 4, 14:25
Unknown Object (File)
Sat, May 4, 14:25
Unknown Object (File)
Sat, May 4, 13:25
Unknown Object (File)
Sat, May 4, 12:29
Unknown Object (File)
Sat, Apr 27, 03:29
Unknown Object (File)
Thu, Apr 25, 22:40

Details

Summary

Convert the "Page Size" field from PhabricatorSearchTextField to PhabricatorSearchIntField as its input should be an integer value (the number of tasks to display in the query results).

Closes T15723

Test Plan
  • Go to /maniphest/query/advanced/
  • enter random values in the Page Size field and run random Maniphest queries (example values: 13, 0, -13, foobar, foo13bar, -foo1313, 13.5, -13.5, 13,5, -13,5, -, -0).

Diff Detail

Repository
rP Phorge
Branch
maniphestPageSizeFieldInt (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1044
Build 1044: arc lint + arc unit