Fix PHP 8.1 exceptions rendering task when custom select field configured
ClosedPublic
Actions

Authored by aklapper on Dec 5 2023, 03:03.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15683: PHP 8.1 "strlen(null)" exceptions rendering Maniphest task when custom select field configured

Commits

rPe610e739cb42: Fix PHP 8.1 exceptions rendering task when custom select field configured

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

In the other case, do not call json_decode() when passing null to it.

EXCEPTION: (RuntimeException) json_decode(): Passing null to parameter #1 ($json) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #1 <#2> json_decode(NULL, boolean) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php:44]

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php:76]

Closes T15683

Test Plan

After configuring a custom select field, access a task.

Diff Detail

Repository

rP Phorge

Branch

ExceptionCustomTextField (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 968
Build 968: arc lint + arc unit

Event Timeline

aklapper created this revision.Dec 5 2023, 03:03

Owners added a reviewer: O1: Blessed Committers.Dec 5 2023, 03:03

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 5 2023, 03:03

aklapper requested review of this revision.Dec 5 2023, 03:03

Harbormaster completed remote builds in B968: Diff 1560.Dec 5 2023, 03:03

aklapper retitled this revision from Fix PHP 8.1 exceptions rendering task when custom text field configured to Fix PHP 8.1 exceptions rendering task when custom select field configured.Dec 5 2023, 03:06

aklapper edited the test plan for this revision. (Show Details)

speck accepted this revision.Dec 5 2023, 12:03

This revision is now accepted and ready to land.Dec 5 2023, 12:03

Closed by commit rPe610e739cb42: Fix PHP 8.1 exceptions rendering task when custom select field configured. · Explain WhyDec 5 2023, 18:24

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPe610e739cb42: Fix PHP 8.1 exceptions rendering task when custom select field configured.

aklapper mentioned this in D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.Dec 6 2023, 19:24

aklapper mentioned this in rP40d10fbe1ae6: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.Jan 12 2024, 01:05