Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink()
ClosedPublic
Actions

Authored by aklapper on Nov 29 2023, 14:45.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15680: Transaction Log after renaming Pholio Mock image: Unhandled Exception: Call to undefined method PholioImageSequenceTransaction::renderHandleLink()

Commits

rPacedbd022d45: Fix exception in Transaction Log after renaming Pholio Mock image: Call to…

Summary

Replace call to undefined renderHandleLink() with renderHandle().

Additionally, pass head_key($new) instead of key($new). This might not be needed strictly speaking for this very issue but should not harm either as several images in a mock can be renamed at once.

EXCEPTION: (Error) Call to undefined method PholioImageSequenceTransaction::renderHandleLink() at [<phorge>/src/applications/pholio/xaction/PholioImageSequenceTransaction.php:32]

Closes T15680

Test Plan

Rename the title of an image in a Pholio mock.
Go to /feed/transactions/query/all/ which now renders instead of showing an error, and shows two entries:
user renamed an image (newname.jpg) from oldname.jpg to newname.jpg. and user updated an image's (newname.jpg) sequence.

(However, separate T15679 will still show up in the error log after this change.)

Diff Detail

Repository

rP Phorge

Branch

T15680PholioRename (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 959
Build 959: arc lint + arc unit

Event Timeline

aklapper created this revision.Nov 29 2023, 14:45

Owners added a reviewer: O1: Blessed Committers.Nov 29 2023, 14:45

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 29 2023, 14:45

aklapper requested review of this revision.Nov 29 2023, 14:45

Harbormaster completed remote builds in B959: Diff 1549.Nov 29 2023, 14:45

aklapper edited the summary of this revision. (Show Details)Nov 29 2023, 14:57

Was this the result of a recent change?

speck added inline comments.Nov 29 2023, 16:21

src/applications/pholio/xaction/PholioImageSequenceTransaction.php
32	Do you mean this to be `head(key($new))`?

In D25482#13939, @speck wrote:

Was this the result of a recent change?

I do not know; however I do not think so. I can imagine it's just Pholio poorly handling changes to the overall mock vs its image(s) in some places (cf D25441).