Fix doc link to Restarting Phorge
ClosedPublic
Actions

Authored by • l2dy on Nov 8 2023, 14:15.

Details

Reviewers

valerio.bozzolan
speck

Group Reviewers

O1: Blessed Committers

Commits

rPce5e0f3e333e: Fix doc link to Restarting Phorge

Summary

See Q81. Link to /diviner/find/ could not find the documentation because it was renamed to "Restarting Phorge".

Test Plan

Uninstall optional PHP extension zip and restart Phorge
Vist /config/issue/ and click on a missing extension issue
Click on the documentation link to Restarting

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 896
Build 896: arc lint + arc unit

Event Timeline

• l2dy created this revision.Nov 8 2023, 14:15

Owners added a reviewer: O1: Blessed Committers.Nov 8 2023, 14:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 8 2023, 14:15

• l2dy requested review of this revision.Nov 8 2023, 14:15

Harbormaster completed remote builds in B896: Diff 1456.Nov 8 2023, 14:15

I've tested this locally with:

$ php -a
require 'scripts/init/init-script.php';
echo PhabricatorEnv::getDoclink('Restarting Phabricator');
echo PhabricatorEnv::getDoclink('Restarting Phorge');

Resulting in:

https://we.phorge.it/diviner/find/?name=Restarting%20Phabricator&type=article&jump=1

https://we.phorge.it/diviner/find/?name=Restarting%20Phorge&type=article&jump=1

So indeed the second works :)

Thanks for this change!

This revision is now accepted and ready to land.Nov 8 2023, 17:51

Would there be a bunch of these lying around?

In D25459#13138, @speck wrote:

Would there be a bunch of these lying around?

Probably but I cannot catch them. No other results with:

$ grep -R " Phabricator'" --include="*.php" .

Closed by commit rPce5e0f3e333e: Fix doc link to Restarting Phorge. · Explain WhyNov 9 2023, 11:34

This revision was automatically updated to reflect the committed changes.

• l2dy added a commit: rPce5e0f3e333e: Fix doc link to Restarting Phorge.

• l2dy mentioned this in Q81: Documentation for "Restarting Phabricator" is missing (Answer 110).Nov 12 2023, 10:58

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

config/

view/

PhabricatorSetupIssueView.php

4 lines

O1: Blessed Committers

Diff 1456

View Options

src/applications/config/view/PhabricatorSetupIssueView.php

Fix doc link to Restarting PhorgeClosedPublicActions