Correct Transaction text when changing Diffusion URI I/O type
ClosedPublic
Actions

Authored by aklapper on Sep 27 2023, 16:51.

Tags

None

Referenced Files

	F3318424: D25443.1743283851.diff
	Fri, Mar 28, 21:30

	F3315267: D25443.1743238387.diff
	Fri, Mar 28, 08:53

	F3310195: D25443.1743191908.diff
	Thu, Mar 27, 19:58

	F3309154: D25443.1743182471.diff
	Thu, Mar 27, 17:21

	F3306971: D25443.1743135148.diff
	Thu, Mar 27, 04:12

	F3300627: D25443.1743044134.diff
	Wed, Mar 26, 02:55

	F3294065: D25443.1742928220.diff
	Mon, Mar 24, 18:43

	F3285696: D25443.1742807181.diff
	Sun, Mar 23, 09:06

Subscribers

Tokens

"Like" token, awarded by valerio.bozzolan.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15648: Transaction text when changing Diffusion URI I/O type is about Display type instead

Commits

rP03afb97ff20b: Correct Transaction text when changing Diffusion URI I/O type

Summary

After changing the I/O type of a Diffusion repository URI, the transaction history incorrectly shows a message which talks about changing the URI's Display type instead.

Closes T15648

Test Plan

Change the I/O type of a Diffusion repo URI and look at that URIs history.

Diff Detail

Repository

rP Phorge

Branch

DiffusionURIwrongString (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 854
Build 854: arc lint + arc unit

Event Timeline

aklapper created this revision.Sep 27 2023, 16:51

Owners added a reviewer: O1: Blessed Committers.Sep 27 2023, 16:51

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 27 2023, 16:51

Harbormaster completed remote builds in B854: Diff 1400.Sep 27 2023, 16:51

aklapper requested review of this revision.Sep 27 2023, 16:51

avivey accepted this revision.Sep 27 2023, 20:12

This revision is now accepted and ready to land.Sep 27 2023, 20:12

valerio.bozzolan edited the summary of this revision. (Show Details)Sep 27 2023, 20:46

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan awarded a token.

Closed by commit rP03afb97ff20b: Correct Transaction text when changing Diffusion URI I/O type. · Explain WhySep 28 2023, 07:20

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP03afb97ff20b: Correct Transaction text when changing Diffusion URI I/O type.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

repository/

storage/

PhabricatorRepositoryURITransaction.php

2 lines

O1: Blessed Committers

Diff 1400

View Options

src/applications/repository/storage/PhabricatorRepositoryURITransaction.php

Correct Transaction text when changing Diffusion URI I/O typeClosedPublicActions