Fix a PHP 8.1 deprecated use of strlen with a NULL argument
ClosedPublic
Actions

Authored by bob on Aug 16 2023, 15:38.

Details

Reviewers

Sten
avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository

Commits

rP8876f75fbb99: Fix a PHP 8.1 deprecated use of strlen with a NULL argument

Summary

This call is preventing users to browse Subversion repositories.
Using strlen() to check string validity is deprecated since PHP 8.1, phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Fix T15608

Test Plan

Sign in
Open a Diffusion SVN repository
You should see the repository instead of getting a Runtime Exception

Diff Detail

Repository

rP Phorge

Branch

diffusion-svn-exception

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 767
Build 767: arc lint + arc unit

Event Timeline

bob created this revision.Aug 16 2023, 15:38

Owners added a reviewer: O1: Blessed Committers.Aug 16 2023, 15:38

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2023, 15:38

bob requested review of this revision.Aug 16 2023, 15:38

Harbormaster completed remote builds in B767: Diff 1273.Aug 16 2023, 15:38

bob edited the summary of this revision. (Show Details)Aug 16 2023, 15:43

bob added a task: T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository.

bob mentioned this in D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 16 2023, 16:05

bob mentioned this in D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 16 2023, 16:17

bob mentioned this in rP6ec89e9f0866: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 18 2023, 10:48

valerio.bozzolan retitled this revision from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument to Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 18 2023, 11:04

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan edited the test plan for this revision. (Show Details)