Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster
ClosedPublic

Authored by aklapper on Aug 6 2023, 20:47.
Tags
None
Referenced Files
F3330451: D25377.1743489492.diff
Mon, Mar 31, 06:38
F3319621: D25377.1743311895.diff
Sat, Mar 29, 05:18
F3303914: D25377.1743088882.diff
Wed, Mar 26, 15:21
F3303520: D25377.1743082480.diff
Wed, Mar 26, 13:34
F3303055: D25377.1743075357.diff
Wed, Mar 26, 11:35
F3301599: D25377.1743054728.diff
Wed, Mar 26, 05:52
F3298295: D25377.1742999737.diff
Tue, Mar 25, 14:35
F3298193: D25377.1742998562.diff
Tue, Mar 25, 14:16

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=customOAuthUrlencodeNull, ref.master=788098096e11, ref.customOAuthUrlencodeNull=4f0f2043b7e9), phorge(head=master, ref.master=226f3150933d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/harbormaster/controller/HarbormasterStepEditController.php:142]

Closes T15592

Test Plan

Add a build step for an existing Harbormaster Build Plan, see that page New Step: Drydock: Run Command is correctly rendered at /harbormaster/step/new/1/HarbormasterDrydockCommandBuildStepImplementation/

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable