The linter's behavior was changed in https://github.com/jshint/jshint/issues/3444: "warnings" are no longer counted for maxerr.
Updating the test to match...
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rARC6832afc30026: Fix jshint tests
arc unit src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php with a recent-ish (2.13.6) jshint.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 688 Build 688: arc lint + arc unit
Event Timeline
Comment Actions
Interestingly, I think arc unit didn't find any tests to run... I triggered this explicitly.
Comment Actions
Everything before the first ~~~~~ line is copied to a new file, and the relevant linter is called on that file.
The stuff after the first ~~~~ line is the expected output (expected lint messages).
If there's a second ~~~~ line, the stuff after it has some more instructions to the linter.
The implementation of this is mostly in https://we.phorge.it/source/arcanist/browse/master/src/lint/linter/__tests__/ArcanistLinterTestCase.php$61.
Comment Actions
I honestly still do not understand what is happening here, what does it mean disabled:3:1:E043 or error:3:1:E019 or anything, but:
- IT'S AVIVEY \o/ WE TRUST AVIVEY
- IT WORKS \o/
$ arc unit src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php PASS 592ms ArcanistJSHintLinterTestCase::testVersion PASS 4.7s ArcanistJSHintLinterTestCase::testLinter
