Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches
ClosedPublic

Authored by aklapper on Jun 4 2023, 10:00.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 04:46
Unknown Object (File)
Sun, Apr 28, 18:37
Unknown Object (File)
Sat, Apr 27, 05:18
Unknown Object (File)
Sun, Apr 7, 08:50
Unknown Object (File)
Apr 1 2024, 01:58
Unknown Object (File)
Mar 31 2024, 03:09
Unknown Object (File)
Mar 27 2024, 17:02
Unknown Object (File)
Mar 25 2024, 00:28

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=b325304b6e52), phorge(head=SvnRepoMain, ref.master=cb938d869c3f, ref.SvnRepoMain=cb938d869c3f)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diffusion/controller/DiffusionController.php:156]

Closes T15446

Test Plan

After applying this change, going to a newly created SVN repository at /diffusion/1/, the page renders, showing the repository as Inactive and also "Empty Repository - This repository does not have any commits yet." as expected.

Diff Detail

Repository
rP Phorge
Branch
SvnRepoMain (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 513
Build 513: arc lint + arc unit