Ref T15064
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15064: Make Phorge compatible with PHP 8.1/8.2/8.3
- Commits
- rP9aafbb42ef8d: fix strlen in PhabricatorMailManagementShowOutboundWorkflow
run ./bin/mail show-outbound --id 1 on a non-html email with php 8.1, no crash.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 509 Build 509: arc lint + arc unit
Event Timeline
Comment Actions
Nice
Followed the test plan.
Maybe we can add a small PHPDoc in PhabricatorMetaMTAMail::getHTMLBody() to make it clear that it @return string|null
src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php | ||
---|---|---|
77 ↗ | (On Diff #1036) | The default for most args is "null", so it was crashing here. This was just a default-check anyway, |
src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php | ||
---|---|---|
77 ↗ | (On Diff #1036) | Yep. Also I wonder why they have not used also $args->getArg('type', $something_else); before. |