Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page
ClosedPublic
Actions

Authored by aklapper on May 29 2023, 11:18.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15425: PHP 8.1 "strlen(null)" exception blocks rendering Conduit's dashboard.panel.edit page

Commits

rP72fdf232b4ab: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15425

Test Plan

Applied this change; afterwards /conduit/method/dashboard.panel.edit/ correctly renders in browser.

Diff Detail

Repository

rP Phorge

Branch

conduitDashboardPanelEdit (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 476
Build 476: arc lint + arc unit

Event Timeline

aklapper created this revision.May 29 2023, 11:18

Owners added a reviewer: O1: Blessed Committers.May 29 2023, 11:18

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 29 2023, 11:18

Harbormaster completed remote builds in B476: Diff 835.May 29 2023, 11:18

aklapper requested review of this revision.May 29 2023, 11:18

Thaanks

I visited every single Conduit API .edit page and I was able to see that every page has a documentation type = NULL, but /conduit/method/owners.edit/ has a nice raw Remarkup string for example. Really no other thing.

So, phutil_nonempty_string() will report alien types, and that is good here.

sgtm