Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse Herald Rules" dialog
ClosedPublic
Actions

Authored by aklapper on May 26 2023, 21:34.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15422: PHP 8.1 "preg_match(null)" exception blocks rendering the "Browse Herald Rules" dialog

Commits

rP1dd9609beddb: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse…

Summary

preg_match() does not accept passing null as the $subject string parameter in PHP 8.1.

Thus first check that $subject !== null.

EXCEPTION: (RuntimeException) preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=0e32dbc1ac8f), phorge(head=diffusionRepoPage, ref.master=5405134fa5db, ref.diffusionRepoPage=dbe5e3a68c41)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #1 <#2> preg_match(string, NULL) called at [<phorge>/src/applications/herald/typeahead/HeraldRuleDatasource.php:25]

Closes T15422

Test Plan

Applied this change; afterwards on the "Diffusion 🡒 Push Logs 🡒 Advanced Search" page at /diffusion/pushlog/?repositories=PHID-REPO-someRepositoryString, clicking the search icon for the "Blocked By" field correctly renders.the "Browse Herald Rules" overlay dialog, listing available Herald rules.

Diff Detail

Repository

rP Phorge

Branch

DiffusionBlockedByHerald (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 463
Build 463: arc lint + arc unit

Event Timeline

aklapper created this revision.May 26 2023, 21:34

Owners added a reviewer: O1: Blessed Committers.May 26 2023, 21:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 26 2023, 21:34

aklapper requested review of this revision.May 26 2023, 21:34

Harbormaster completed remote builds in B462: Diff 816.May 26 2023, 21:34

Shorten 87 char line to pass linter

Harbormaster completed remote builds in B463: Diff 817.May 26 2023, 21:36

aklapper edited the summary of this revision. (Show Details)May 30 2023, 14:58

Thanks again :) Soft +1

Also here our phutil is maybe overkill since an emtpy string is a don't care. So a strict check anti-null is probably safer:

$raw_query !== null

Hard +1 in that case from me. Thanks again

Edted: also updating a bit the summary.

Use $raw_query !== null as requested

Harbormaster completed remote builds in B494: Diff 859.May 31 2023, 06:05

Thanks for your minimal change

(tip: no need to use brackets, but that is up to readability preferences I guess)

sgtm

This revision is now accepted and ready to land.May 31 2023, 07:09

aklapper retitled this revision from Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Browse Herald Rules" dialog to Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse Herald Rules" dialog.May 31 2023, 07:37

aklapper edited the summary of this revision. (Show Details)

Closed by commit rP1dd9609beddb: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse…. · Explain WhyMay 31 2023, 07:38

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP1dd9609beddb: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse….