Paths

Table of Contentst

Differential D25229

Fix PHP 8.1 "explode(null)" exception which blocks rendering "Provide Multi-Factor Credentials" page
ClosedPublic
Actions

Authored by aklapper on May 13 2023, 13:48.

Tags

None

Referenced Files

	F2163700: D25229.id773.diff
	Thu, Apr 25, 14:26

	F2163698: D25229.id771.diff
	Thu, Apr 25, 14:26

	F2163697: D25229.id737.diff
	Thu, Apr 25, 14:26

	F2163639: D25229.id.diff
	Thu, Apr 25, 13:50

	F2163609: D25229.diff
	Thu, Apr 25, 13:40

	Unknown Object (File)
	Wed, Apr 24, 02:05

	Unknown Object (File)
	Wed, Apr 17, 06:17

	Unknown Object (File)
	Sun, Apr 7, 08:03

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15397: PHP 8.1 "explode(null)" exception blocks rendering "Provide Multi-Factor Credentials" page

Commits

rP10fae71a042f: Fix PHP 8.1 "explode(null)" exception which blocks rendering "Provide Multi…

Summary

Passing null to the $string in explode(string $separator, string $string, int $limit) is deprecated since PHP 8.1.
Thus do not explode but create an empty array if the input is null.

Closes T15397

Test Plan

Applied this change and afterwards the "Provide Multi-Factor Credentials" page at /auth/finish/ showing the "App Code" field correctly rendered in the web browser.

Diff Detail

Repository

Branch

multifactorauthme (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 413
Build 413: arc lint + arc unit

Event Timeline

aklapper created this revision.May 13 2023, 13:48

Owners added a reviewer: O1: Blessed Committers.May 13 2023, 13:48

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 13 2023, 13:48

aklapper requested review of this revision.May 13 2023, 13:48

Harbormaster completed remote builds in B413: Diff 737.May 13 2023, 13:48

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

Thanks - small tip here

src/applications/auth/storage/PhabricatorAuthChallenge.php
59	Also here probably the minimal change is just the above one

Thanks again for this patch

I talked with the kind user aklapper about the proposed minimal change and, hoping to be useful, I will amend that small thing

I tested this locally and this works

This revision is now accepted and ready to land.May 20 2023, 20:27

amend a small thing we discussed in live

Harbormaster completed remote builds in B431: Diff 771.May 20 2023, 20:28

valerio.bozzolan accepted this revision.May 20 2023, 20:29

valerio.bozzolan edited the summary of this revision. (Show Details)

Closed by commit rP10fae71a042f: Fix PHP 8.1 "explode(null)" exception which blocks rendering "Provide Multi…. · Explain WhyMay 21 2023, 05:57

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP10fae71a042f: Fix PHP 8.1 "explode(null)" exception which blocks rendering "Provide Multi….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

storage/

PhabricatorAuthChallenge.php

6 lines

O1: Blessed Committers

Diff 737

src/applications/auth/storage/PhabricatorAuthChallenge.php

Loading...