Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number
ClosedPublic
Actions

Authored by aklapper on May 10 2023, 17:59.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15382: PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number

Commits

rP26aed4935b55: Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15382

Test Plan

Applied this change and after performing steps to send a test message again, /mail/detail/107/ page got rendered correctly
and I can see the "Status Details" with stuff like "None" or "No mailers are configured."

Diff Detail

Repository

rP Phorge

Branch

phoneMeHome (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 392
Build 392: arc lint + arc unit

Event Timeline

aklapper created this revision.May 10 2023, 17:59

Owners added a reviewer: O1: Blessed Committers.May 10 2023, 17:59

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 10 2023, 17:59

aklapper requested review of this revision.May 10 2023, 17:59

Harbormaster completed remote builds in B392: Diff 711.May 10 2023, 17:59

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

Thanks for this patch, again! :)

I tested this locally, trying multiple pages related to mails, without any nuclear implosion.

Apparently this just generates the Status Details that should always be null or a string. The function phutil_nonempty_string()} will report any alien type like objects, and that is good here.

sgtm