Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog
ClosedPublic
Actions

Authored by aklapper on May 10 2023, 14:27.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15380: PHP 8.1 "strlen(null)" exceptions block rendering "Browse Projects" overlay dialog

Commits

rPbac87ca2646b: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects"…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15380

Test Plan

Applied these two changes (on top of D25179) and on the task creation page, after clicking the magnifier icon in the "Tags" field, the "Browse Projects" overlay dialog got rendered.

Diff Detail

Repository

rP Phorge

Branch

typeaheadProjects (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 390
Build 390: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	95 ms	PhabricatorProjectCoreTestCase::testAncestorMembers EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	84 ms	PhabricatorProjectCoreTestCase::testColumnExtendedPolicies EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	152 ms	PhabricatorProjectCoreTestCase::testEditProject EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	67 ms	PhabricatorProjectCoreTestCase::testIsViewerMemberOrWatcher EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	244 ms	PhabricatorProjectCoreTestCase::testJoinLeaveProject EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
		View Full Test Results (9 Failed · 21 Passed)

Event Timeline

aklapper created this revision.May 10 2023, 14:27

Owners added a reviewer: O1: Blessed Committers.May 10 2023, 14:27

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 10 2023, 14:27

aklapper requested review of this revision.May 10 2023, 14:27

Harbormaster completed remote builds in B390: Diff 709.May 10 2023, 14:27

aklapper edited the test plan for this revision. (Show Details)May 10 2023, 14:40

aklapper edited the test plan for this revision. (Show Details)

aklapper mentioned this in T15381: PHP 8.1 "strlen(null)" and preg_match() exceptions block rendering "Browse Subscribers" overlay dialog.May 10 2023, 14:45

aklapper mentioned this in D25214: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog.May 10 2023, 14:46

Thanks (again)

I tested this patch locally following the test plan. No implosions.

Also tested with various Typehead like Subscribers.

sgtm

src/applications/project/typeahead/PhabricatorProjectDatasource.php
86	✅ I verified that the above line just contains a string (or maybe null for some weird cases). The function `phutil_nonempty_string()` will report alien types (like objects), and that is OK.
135	✅ Same as above