Page MenuHomePhorge

Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address
ClosedPublic

Authored by aklapper on May 9 2023, 21:04.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 08:37
Unknown Object (File)
Tue, Mar 26, 07:57
Unknown Object (File)
Tue, Mar 26, 07:28
Unknown Object (File)
Sun, Mar 24, 06:35
Unknown Object (File)
Sat, Mar 23, 00:10

Details

Summary

Since PHP 8.1, passing a null string to ltrim(string $string) is deprecated.

Thus we make sure that $request->getStr('email') does not return null as default.

Closes T15376

Test Plan

Applied this change, afterwards repeated the steps to add a new email address on /settings/panel/email/. This time, it's possible to close the "Verification Email Sent" and the page /settings/panel/email/ renders and lists the new email address.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.May 9 2023, 21:04

Thanks

Please see my inline comment, probably just adding 3 characters fixes, and that would be probably the approach from O1

I accept as behalf of myself in the meanwhile, thanks

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
175

Probably the exact minimal fix is just that.

Kind of "don't care" logic.

Yep I confirm my opinion here, let's ping-pong this tomorrow

This revision now requires changes to proceed.May 19 2023, 23:03

(it works indeed, so no need from me to red block)

valerio.bozzolan edited the summary of this revision. (Show Details)

Thanks again :)

I tested this locally following the test plan without any nuclear implosion. Green light from me

lgtm

This revision is now accepted and ready to land.May 20 2023, 12:03