Fix PHP 8.1 "strlen(null)" exception which blocks blog creation
ClosedPublic
Actions

Authored by aklapper on May 6 2023, 10:11.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15355: PHP 8.1 "strlen(null)" exception blocks blog creation

Commits

rP8495060f8240: Fix PHP 8.1 "strlen(null)" exception which blocks blog creation

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15355

Test Plan

Applied this change and /phame/blog/manage/3/ correctly rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

createBlog (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 365
Build 365: arc lint + arc unit

Event Timeline

aklapper created this revision.May 6 2023, 10:11

Owners added a reviewer: O1: Blessed Committers.May 6 2023, 10:11

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 6 2023, 10:11

Harbormaster completed remote builds in B365: Diff 669.May 6 2023, 10:11

aklapper requested review of this revision.May 6 2023, 10:11

aklapper mentioned this in T15356: PHP 8.1 "strlen(null)" exception blocks rendering a blog.May 6 2023, 10:22

aklapper mentioned this in D25195: Fix PHP 8.1 "strlen(null)" exception which blocks blog rendering.May 6 2023, 10:23

Tested locally, verified that the domain is never a PhutilURI. No implosions.

Thanks

sgtm

src/applications/phame/storage/PhameBlog.php
172	✅ I verified the above line The variable comes from the string input field "Full Domain URI" in the page `/phame/blog/edit/<number>/` and always is null or a string and never an object. The function `phutil_nonempty_string()` will report alien types, and that is OK.