Fix PHP 8.1 "strlen(null)" exception which blocks Space creation
ClosedPublic
Actions

Authored by aklapper on May 4 2023, 11:29.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15340: PHP 8.1 "strlen(null)" exception blocks Space creation

Commits

rP519acd9a104e: Fix PHP 8.1 "strlen(null)" exception which blocks Space creation

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15340

Test Plan

Applied this change and page /S3 rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

createSpace (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 354
Build 354: arc lint + arc unit

Event Timeline

aklapper created this revision.May 4 2023, 11:29

Owners added a reviewer: O1: Blessed Committers.May 4 2023, 11:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 4 2023, 11:29

Harbormaster completed remote builds in B354: Diff 651.May 4 2023, 11:29

aklapper requested review of this revision.May 4 2023, 11:29

Thanks for this patch, again

I tested this patch locally. I was able to create a Space, rename a Space, etc., without any nuclear implosion.

Thanks

Green light

yesyes

src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php
18	✅ The value `$old` always is NULL at startup, or is a string after a rename. The function `phutil_nonempty_string()` will report any alien type, and that is OK.