Fix PHP 8.1 "strlen(null)" exceptions which block rendering the "Add Panel to Dashboard" overlay dialog
ClosedPublic
Actions

Authored by aklapper on Apr 30 2023, 11:58.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15305: PHP 8.1 "strlen(null)" exceptions block rendering the "Add Panel to Dashboard" overlay dialog

Commits

rP456ba873ca01: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the "Add Panel to…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15305

Test Plan

Applied these two changes (on top of D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153, D25154)) and "Use Results -> Add Panel to Dashboard"
overlay dialog finally rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

dashboardAdd (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 303
Build 303: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 30 2023, 11:58

Owners added a reviewer: O1: Blessed Committers.Apr 30 2023, 11:58

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 30 2023, 11:58

aklapper requested review of this revision.Apr 30 2023, 11:58

Harbormaster completed remote builds in B303: Diff 569.Apr 30 2023, 11:59

valerio.bozzolan accepted this revision.Apr 30 2023, 12:25

valerio.bozzolan added inline comments.

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
16	✅ This is always a string, something like: `"PhabricatorPeopleLogSearchEngine"`. Alien values will be reported and it's OK.
21	✅ This is always a (random) string, something like: `"NMQOq_OGAH2B"`. Alien values will be reported and it's OK.