Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the "Add Panel to Dashboard" overlay dialog
ClosedPublic

Authored by aklapper on Apr 30 2023, 11:58.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 20:52
Unknown Object (File)
Fri, Jun 14, 19:33
Unknown Object (File)
Fri, Jun 14, 08:25
Unknown Object (File)
Fri, Jun 14, 07:39
Unknown Object (File)
Wed, Jun 12, 06:15
Unknown Object (File)
Fri, Jun 7, 16:17
Unknown Object (File)
May 9 2024, 02:45
Unknown Object (File)
May 9 2024, 02:30

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15305

Test Plan

Applied these two changes (on top of D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153, D25154)) and "Use Results -> Add Panel to Dashboard"
overlay dialog finally rendered in web browser.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
16

✅ This is always a string, something like: "PhabricatorPeopleLogSearchEngine". Alien values will be reported and it's OK.

21

✅ This is always a (random) string, something like: "NMQOq_OGAH2B". Alien values will be reported and it's OK.

This revision is now accepted and ready to land.Apr 30 2023, 12:25