Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conpherence page
ClosedPublic
Actions

Authored by aklapper on Apr 30 2023, 11:30.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15304: PHP 8.1 "strlen(null)" exceptions block rendering the Conpherence page

Commits

rPe65ac7b8800d: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conpherence page

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15304

Test Plan

Applied these four changes (on top of D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153) and /conpherence/ page finally rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

D25154 (branched from master)

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/applications/conpherence/query/ConpherenceThreadQuery.php:138	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 300
Build 300: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 30 2023, 11:30

Owners added a reviewer: O1: Blessed Committers.Apr 30 2023, 11:30

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 30 2023, 11:30

aklapper requested review of this revision.Apr 30 2023, 11:30

Harbormaster completed remote builds in B300: Diff 566.Apr 30 2023, 11:30

valerio.bozzolan added inline comments.Apr 30 2023, 15:26

src/applications/conpherence/query/ConpherenceThreadQuery.php
138	OH NO

valerio.bozzolan added inline comments.Apr 30 2023, 15:39

src/applications/conpherence/query/ConpherenceThreadQuery.php
138	✅ I logged this locally and it seems this is just the user query for fulltext search, and its input domain is just NULL or string. The `phutil_nonempty_string()` will report alien values and this is OK.
155	✅ I logged this locally and it seems this is just the user query for fulltext search, and its input domain is just NULL or string. The `phutil_nonempty_string()` will report alien values and this is OK.
237	✅ I logged this locally and it seems this is just the user query for fulltext search, and its input domain is just NULL or string. The `phutil_nonempty_string()` will report alien values and this is OK.
src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
109	✅ I logged this locally and it seems this is just the user query for fulltext search, and its input domain is just NULL or string. The `phutil_nonempty_string()` will report alien values and this is OK.

make linter happy about line longer than 80 characters

Harbormaster completed remote builds in B308: Diff 577.Apr 30 2023, 15:39

I tested this locally without any explosion related to alien checks of phutil_nonempty_string(). I was able to use Conpherence, search stuff, search full text, etc. Thanks

yesyes