Differential D25047

Rebrand: Rename library and update "version" logic
ClosedPublic
Actions

Authored by avivey on Aug 20 2022, 08:15.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15006: Re-brand Phorge

Commits

rPdbf7cd2b4a1a: Rebrand: Rename library and update "version" logic

Summary

Make the "version" data in Config show information. Also rename the library.

Test Plan

See version "branched from" information.

Diff Detail

Repository

Branch

phorge (branched from master)

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/applications/config/controller/PhabricatorConfigConsoleController.php:177	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 76
Build 76: arc lint + arc unit

Event Timeline

avivey created this revision.Aug 20 2022, 08:15

Owners added a reviewer: O1: Blessed Committers.Aug 20 2022, 08:15

Herald added subscribers: Matthew, valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptAug 20 2022, 08:15

avivey requested review of this revision.Aug 20 2022, 08:15

Harbormaster completed remote builds in B76: Diff 255.Aug 20 2022, 08:15

avivey added a task: T15006: Re-brand Phorge.Aug 20 2022, 08:15

lint

Harbormaster completed remote builds in B77: Diff 256.Aug 20 2022, 13:05

speck accepted this revision.Aug 20 2022, 14:18

speck added inline comments.

src/applications/config/controller/PhabricatorConfigConsoleController.php
175–178	For a future change/discussion - it might make sense to have this be configurable. We run a forked version of phab/arcanist (without this bit modified~) and it's bitten us when setting up or updating. Since our install clones from an internal repo we have to make sure a specific remote exists in the repository even though it's not used.

This revision is now accepted and ready to land.Aug 20 2022, 14:18

Closed by commit rPdbf7cd2b4a1a: Rebrand: Rename library and update "version" logic. · Explain WhyAug 25 2022, 08:26

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPdbf7cd2b4a1a: Rebrand: Rename library and update "version" logic.

Revision Contents
Changeset List

Path

Size

Packages

src/

__phutil_library_init__.php

2 lines

O1: Blessed Committers

applications/

config/

controller/

PhabricatorConfigConsoleController.php

4 lines

O1: Blessed Committers

Diff 255

src/__phutil_library_init__.php

Loading...

src/applications/config/controller/PhabricatorConfigConsoleController.php

Loading...