Paths

Table of Contentst

Differential D25046

Rebrand: Change Server name
ClosedPublic
Actions

Authored by avivey on Aug 20 2022, 08:06.

Tags

None

Referenced Files

	F2157204: D25046.diff
	Wed, Apr 24, 12:19

	F2156904: D25046.id260.diff
	Wed, Apr 24, 02:51

	Unknown Object (File)
	Mon, Apr 22, 21:25

	Unknown Object (File)
	Mon, Apr 22, 21:25

	Unknown Object (File)
	Mon, Apr 22, 19:09

	Unknown Object (File)
	Mon, Apr 22, 18:48

	Unknown Object (File)
	Sun, Apr 21, 16:11

	Unknown Object (File)
	Sat, Apr 20, 05:53

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15006: Re-brand Phorge

Commits

rARC42a51e15f4d8: Promote 2022.37 to stable
rARC0c0b9644a6a8: Rebrand: Change Server name

Summary

Use the name "Phorge" as the defined platform.

Also prepare to rename the core library "phorge" rather then "phabricator" - see next diff.

Test Plan

Deployed change, tooltip for "Config" shows "Configure Phorge"

Diff Detail

Repository

Branch

illyrica (branched from master)

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/init/lib/PhutilBootloader.php:195	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 75
Build 75: arc lint + arc unit

Event Timeline

avivey created this revision.Aug 20 2022, 08:06

Owners added a reviewer: O1: Blessed Committers.Aug 20 2022, 08:06

Herald added subscribers: Matthew, valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptAug 20 2022, 08:06

avivey requested review of this revision.Aug 20 2022, 08:06

Harbormaster completed remote builds in B75: Diff 254.Aug 20 2022, 08:06

avivey edited the summary of this revision. (Show Details)Aug 20 2022, 08:15

avivey added a task: T15006: Re-brand Phorge.

speck added inline comments.Aug 20 2022, 13:51

src/init/lib/PhutilBootloader.php
194–197	It looks like there are ~61 instances of `phutil_get_library_root('phabricator')` in the phorge repo. Is the plan to eventually replace those?

avivey added inline comments.Aug 20 2022, 18:11

src/init/lib/PhutilBootloader.php
194–197	Probably, at some point. There's also the word `phabricator` in the Celerity/Javeline parts, and other infra stuff that is not exactly user-facing, but a bit public.

speck accepted this revision.Aug 20 2022, 19:05

This revision is now accepted and ready to land.Aug 20 2022, 19:05

Closed by commit rARC0c0b9644a6a8: Rebrand: Change Server name. · Explain WhyAug 25 2022, 08:25

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rARC0c0b9644a6a8: Rebrand: Change Server name.

Matthew added a commit: rARC42a51e15f4d8: Promote 2022.37 to stable.Sep 7 2022, 22:27

Revision Contents
Changeset List

Path

Size

Packages

src/

error/

PhutilErrorHandler.php

1 line

O1: Blessed Committers

init/

lib/

PhutilBootloader.php

4 lines

O1: Blessed Committers

platform/

PlatformSymbols.php

2 lines

O1: Blessed Committers

Diff 254

src/error/PhutilErrorHandler.php

Loading...

src/init/lib/PhutilBootloader.php

Loading...

src/platform/PlatformSymbols.php

Loading...