This fixes most issues with php 8.1. Some issues still linger that I was unable to fix. Part of T15064.
Details
Details
- Reviewers
Ekubischta - Group Reviewers
Blessed Committers O1: Blessed Committers - Maniphest Tasks
- T15198: PHP 8.2 deprecations fix strategies
T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies
T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo)
T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4
Used php linting, tested in browser, checked error logs, etc
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Just a warning that I found a few bugs just by spot checking...
I think that this revision should be abandoned
- It is impossible to test
- Should we be suppressing "null to string" errors with "@" ? (The issue here is that the built in strlen function does not accept null)
I think a better approach would be to
- Write a replacement global function called phorge_strlen
- Replace all strlen functions with our new function
Repeat for any other functions that we feel have this issue
src/console/grid/ArcanistGridView.php | ||
---|---|---|
158 | Find and Replace bug | |
src/console/view/PhutilConsoleList.php | ||
45 | Find and Replace bug | |
src/console/view/PhutilConsoleTable.php | ||
82 | Find and Replace bug | |
228 | Find and Replace bug | |
236 | Find and Replace bug |