Yup. I noticed that probably the method getNewUserBody() should be just moved from PhabricatorDashboardPanelListController to PhabricatorDashboardPanelSearchEngine. Additional details in T15844.

Fri, May 31, 10:10

valerio.bozzolan added a project to T15844: Dashboard Panel list: missing welcome page: Dashboards.

Fri, May 31, 09:13 · Dashboards, Bug Reports

valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

The test plan should be:

Fri, May 31, 08:55

valerio.bozzolan requested changes to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Just try to move the method in PhabricatorDashboardPanelSearchEngine as-is

Fri, May 31, 08:50

valerio.bozzolan added a revision to T15844: Dashboard Panel list: missing welcome page: D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Fri, May 31, 08:49 · Dashboards, Bug Reports

valerio.bozzolan updated the summary of D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Fri, May 31, 08:49

valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Wow, this was super-interesting

Fri, May 31, 08:48

valerio.bozzolan created T15844: Dashboard Panel list: missing welcome page.

Fri, May 31, 08:48 · Dashboards, Bug Reports

Thu, May 30

valerio.bozzolan accepted D25641: Correct call to non-existing PhutilFileLockException in support/unit/lock.php.

Nice!

Thu, May 30, 10:46

valerio.bozzolan updated the test plan for D25641: Correct call to non-existing PhutilFileLockException in support/unit/lock.php.

Thu, May 30, 10:46

valerio.bozzolan accepted D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.

Thu, May 30, 10:39

valerio.bozzolan updated the diff for D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.

restore newline

Thu, May 30, 10:39

valerio.bozzolan accepted D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.

Thanks for the upstream link

Thu, May 30, 10:38

valerio.bozzolan accepted D25673: Fix error in Mercurial when no offset is specified.

Thu, May 30, 10:33

Tue, May 28

valerio.bozzolan accepted D25665: PHPMailer: Remove unused variable.

https://www.reddit.com/r/ProgrammerHumor/comments/9xat04/the_ancient_code/

Tue, May 28, 01:53

Sat, May 25

valerio.bozzolan added a comment to D25671: Remove joke password reset email message.

Well, I understand why this patch completely removes that joke.

Sat, May 25, 07:40

Sun, May 19

valerio.bozzolan accepted D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Thanks asd

Sun, May 19, 05:11

Sat, May 18

valerio.bozzolan awarded D25662: MimeMailParser: Remove an unused variable a Love token.

Sat, May 18, 19:50

valerio.bozzolan created E39: Valerio available (vacation).

Sat, May 18, 19:32

valerio.bozzolan updated the summary of D25651: Fix typo creating QRbitstream().

Sat, May 18, 19:30

valerio.bozzolan updated the diff for D25651: Fix typo creating QRbitstream().

shot at line 1162

Sat, May 18, 19:29

valerio.bozzolan accepted D25651: Fix typo creating QRbitstream().

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

Sat, May 18, 19:26

valerio.bozzolan edited the content of Next Up.

Sat, May 18, 18:55

valerio.bozzolan accepted D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.

I tested this with the following snippet:

Sat, May 18, 18:51

valerio.bozzolan requested changes to D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Sat, May 18, 13:33

valerio.bozzolan accepted D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)

Sat, May 18, 13:17

valerio.bozzolan accepted D25640: Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php.

It was probably confused with the internal API executeRemovePath

Sat, May 18, 13:08

valerio.bozzolan requested changes to D25662: MimeMailParser: Remove an unused variable.

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

Sat, May 18, 12:56

valerio.bozzolan edited the content of 2024 week 19.

Sat, May 18, 12:52

mainframe98 awarded D25626: The feed "created this task" should be the first one a Love token.

Sat, May 18, 08:54

valerio.bozzolan edited the content of Next Up.

Sat, May 18, 08:35

valerio.bozzolan accepted D25549: Add Standard Custom Fields to Item List.

Uh! I like this.

Sat, May 18, 08:35

valerio.bozzolan closed D25080: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Sat, May 18, 08:16 · Workboard

valerio.bozzolan closed T15162: Workboard Trigger Rule: allow to Add/Remove Subscribers as Resolved by committing rPb8a03bc145b1: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Sat, May 18, 08:16 · User-valerio.bozzolan, Trigger, Workboard

valerio.bozzolan committed rPb8a03bc145b1: Workboard Trigger Rule: allow to Add/Remove Subscribers.

Workboard Trigger Rule: allow to Add/Remove Subscribers

Sat, May 18, 08:16

valerio.bozzolan edited the content of Next Up.

Sat, May 18, 08:15

valerio.bozzolan added a parent task for T15133: Differential List View should show Repository: T15750: Integrate CustomField into more interfaces.

Sat, May 18, 08:14 · Differential

valerio.bozzolan added a subtask for T15750: Integrate CustomField into more interfaces: T15133: Differential List View should show Repository.

Sat, May 18, 08:14

valerio.bozzolan closed T15816: The feed "created this task" should be the first one as Resolved.

Probably OK now

Sat, May 18, 08:10 · Bug Reports, User-valerio.bozzolan

valerio.bozzolan edited the content of Template.

Sat, May 18, 08:08

valerio.bozzolan closed D25626: The feed "created this task" should be the first one.

Sat, May 18, 08:05

valerio.bozzolan committed rPf4d9d6920bcd: The feed "created this task" should be the first one.

The feed "created this task" should be the first one

Sat, May 18, 08:05

valerio.bozzolan added inline comments to D25661: PHPMailer: Remove a check for PHP 5.0.

Sat, May 18, 05:30

Fri, May 17

valerio.bozzolan added inline comments to D25602: Do not hardcode default Priority names in Project Reports tooltip.

Fri, May 17, 07:16

Thu, May 16

valerio.bozzolan added inline comments to D25602: Do not hardcode default Priority names in Project Reports tooltip.

Thu, May 16, 20:11

valerio.bozzolan accepted D25650: Correct PHPDoc or add default return for numerous methods.

Thu, May 16, 14:45

valerio.bozzolan awarded D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment a Love token.

Thu, May 16, 12:18

valerio.bozzolan added inline comments to D25642: Initialize $cache_key variable in CelerityResourceController.php.

Thu, May 16, 09:53

Wed, May 15

valerio.bozzolan added a comment to T15828: "Not In" query operator is not respected when searching for project milestones.

Interesting triage. In legacy upstream this was a "feature request 🌈" - https://secure.phabricator.com/T12438

Wed, May 15, 18:01

valerio.bozzolan added a member for Trusted Contributors: dhinus.

Wed, May 15, 15:45

valerio.bozzolan updated subscribers of T15828: "Not In" query operator is not respected when searching for project milestones.

Super-useful comment:

Wed, May 15, 15:45

valerio.bozzolan updated the question details for Q125: "Not In" query operator and searching for project milestones.

Wed, May 15, 15:42

valerio.bozzolan accepted D25638: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.

Wed, May 15, 12:48

valerio.bozzolan updated the test plan for D25638: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.

Wed, May 15, 12:47

valerio.bozzolan added a comment to T15826: PHP 8.1 "strlen(null)" exception rendering image file without $encode_setting.

I don't know if the file is really related, but PhabricatorDocumentRenderingEngine can be seen in scene while surfing a Diffusion repository and playing with View Options.

Wed, May 15, 12:47 · PHP 8 support

valerio.bozzolan accepted D25639: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.

Wed, May 15, 12:42

valerio.bozzolan awarded T15831: Long search query can trigger raw "Too many tables; MariaDB can only use 61 tables in a join" a The World Burns token.

Wed, May 15, 11:59

valerio.bozzolan added a comment to T15110: File reference not removed when file is deleted.

Relevant old upstream comment (from an unrelated task) that describes this problem as "ghosts in the UI":

Wed, May 15, 00:21 · Files, Bug Reports

Tue, May 14

valerio.bozzolan updated the diff for D25080: Workboard Trigger Rule: allow to Add/Remove Subscribers.

adjust strings as suggested, also, renamed classes from "subscriber" to "subscribers"

Tue, May 14, 23:54 · Workboard

valerio.bozzolan placed T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge' up for grabs.

Help welcome.

Tue, May 14, 23:38 · User-valerio.bozzolan

valerio.bozzolan updated the diff for D25622: Transformed Pictures: make them non-orphan.

PhabricatorFileTransform: add null check

Tue, May 14, 23:32

valerio.bozzolan added a comment to D25035: Hide the blurb of a user when that user is disabled.

Thanks again. Generally super-useful.

Tue, May 14, 09:34

valerio.bozzolan added a comment to D25621: Show login page if a search token requires a valid viewer.

Uhm. Incredibly, it seems to work. I have good feelings.

Tue, May 14, 08:59

valerio.bozzolan updated the test plan for D25621: Show login page if a search token requires a valid viewer.

Tue, May 14, 08:58

valerio.bozzolan added a comment to D25636: Fix exception awarding empty badge to user.

In D25636#17842, @aklapper wrote:

Ideally this would be done via validateTransactions using ->setFormErrors($errors) on a PHUIObjectBoxView but all seems quite broken for badges anyway, see T15827.

Tue, May 14, 05:06