Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php
ClosedPublic
Actions

Authored by aklapper on Thu, May 16, 08:45.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC5477568274e3: Correct call to non-existing Filesystem::removePath() in…

Summary

rARC21e80a635d798c5be2c6e5c272497b3170c1e079 introduced a call to non-existing Filesystem::removePath().
Presumably, remove() in src/filesystem/Filesystem.php was meant, so use that function instead.

Test Plan

Unknown, apart from reading and grep'ing the code base.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Thu, May 16, 08:45

Owners added a reviewer: O1: Blessed Committers.Thu, May 16, 08:45

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 16, 08:45

aklapper requested review of this revision.Thu, May 16, 08:45

Harbormaster completed remote builds in B1261: Diff 1991.Thu, May 16, 08:45

Thanks

It was probably confused with the internal API executeRemovePath

This revision is now accepted and ready to land.Sat, May 18, 13:08

Closed by commit rARC5477568274e3: Correct call to non-existing Filesystem::removePath() in…. · Explain WhySat, May 18, 19:39

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC5477568274e3: Correct call to non-existing Filesystem::removePath() in….

Revision Contents
Changeset List

Path

Size

Packages

src/

workflow/

ArcanistDownloadWorkflow.php

2 lines

O1: Blessed Committers

Diff 2022

View Options

src/workflow/ArcanistDownloadWorkflow.php

Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.phpClosedPublicActions