Dashboard Text Panel: Incomplete Transaction "text.text" when changing Description
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	valerio.bozzolan
	Wed, May 8, 09:20

Description

When creating a Dashboard Text Panel, from example from here:

http://phorge.localhost/dashboard/panel/edit/?panelType=text

When you change its Description, you see this internal transaction (but you must have Developer Mode):

foo.bar edited this object (transaction type "text.text").

Screenshot:

Phorge Text Panel with text-text incomplete transaction.png (709×1 px, 69 KB)

Instead, we should show something else.

Troubleshooting

It seems a default phrase generated by PhabricatorApplicationTransaction:

https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorApplicationTransaction.php;af300016b678fd0694a4ecde00de167677acff80$1333

I'm quite sure that any edit should not touch that file, but should create something inside this directory:

https://we.phorge.it/source/phorge/browse/master/src/applications/dashboard/xaction/panel/

Probably there is a missing method getTitle() in PhabricatorDashboardTextPanelTextTransaction:

https://we.phorge.it/source/phorge/browse/master/src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php;af300016b678fd0694a4ecde00de167677acff80

Proposal n. 1

diff --git a/src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php b/src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php
index 1822810c05..0dd417e0f5 100644
--- a/src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php
+++ b/src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php
@@ -9,6 +9,12 @@ final class PhabricatorDashboardTextPanelTextTransaction
     return 'text';
   }
 
+  public function getTitle() {
+    return pht(
+      '%s updated the panel text.',
+      $this->renderAuthor());
+  }
+
   public function newRemarkupChanges() {
     $changes = array();