Differential D25625

Dashboard Text Panel: improve feed when changing Description
ClosedPublic
Actions

Authored by valerio.bozzolan on Wed, May 8, 09:45.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15817: Dashboard Text Panel: Incomplete Transaction "text.text" when changing Description

Commits

rP6514598f6635: Dashboard Text Panel: improve feed when changing Description

Summary

When creating a Dashboard Text Panel, from example from here:

http://phorge.localhost/dashboard/panel/edit/?panelType=text

After you change its Description,

Before this change, this was the feed (but you must have Developer Mode):

foo.bar edited this object (transaction type "text.text").

After this change, this is the feed:

foo.bar edited the the panel text. (Show Details)

So, not only we show a nice title, but we also allow to see details.

Before	After

Credits:

LegalpadDocumentTextTransaction for the getTitle() method
ManiphestTaskDescriptionTransaction for the details

Closes T15817

Test Plan

Create a Text Panel from /dashboard/panel/edit/?panelType=text
Change description
See the new feed
Click on "Show Details". Also that works. You see A/B changes.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Wed, May 8, 09:45

Owners added a reviewer: O1: Blessed Committers.Wed, May 8, 09:45

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptWed, May 8, 09:45

Harbormaster completed remote builds in B1234: Diff 1950.Wed, May 8, 09:45

valerio.bozzolan requested review of this revision.Wed, May 8, 09:45

valerio.bozzolan edited the summary of this revision. (Show Details)Wed, May 8, 09:47

valerio.bozzolan edited the summary of this revision. (Show Details)Wed, May 8, 09:51

valerio.bozzolan added a task: T15817: Dashboard Text Panel: Incomplete Transaction "text.text" when changing Description.

valerio.bozzolan removed a task: T15816: The feed "created this task" should be the first one.

Tested this patch on http://phorge.localhost/feed/transactions/ and in the feed at the bottom of http://phorge.localhost/W20 itself.
Also tested changing panel visibility from Public to Admin only and accessing these URIs as an average user.
All working as expected, no explosions.

This revision is now accepted and ready to land.Wed, May 8, 10:53

Closed by commit rP6514598f6635: Dashboard Text Panel: improve feed when changing Description. · Explain WhyThu, May 9, 16:40

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP6514598f6635: Dashboard Text Panel: improve feed when changing Description.