User Details
- User Since
- Feb 28 2023, 20:44 (63 w, 4 d)
- Availability
- Available
Today
@20after4: Willing to share some code at some point that folks can poke or play with? :) TIA!
Yesterday
Valerio may have a point here :D
I'm stupid and should have really checked the commit history first. Sorry!
Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)
Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.
Fri, May 17
Indentation is awesome
Thu, May 16
Improvicate some things that valerio mentioned. (I prefer "Average" to "Normal" though; I consider "normal" a problematic term in this context.)
It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.
I felt it's not necessarily needed but it cannot hurt either. :)
Wed, May 15
Mon, May 13
Remove variable definition now unneeded outside of the if clause
Here's a revision which does not throw a red box via ->setFormErrors() at the user but at least it is displaying the Required text and turning it into bold red after clicking Award without having defined a recipient. So the line $errors[] = pht('Badge name is required.'); is currently never ever shown.
Thanks for the hints how to improve this! Appreciated.
That was a merged JS change so I should have also run ./bin/celerity map. Sorry. Followup patch in https://we.phorge.it/D25637
Sun, May 12
I don't believe in playing whack-a-mole on "could this be a password" but a use case I've been recently thinking of is "Do not allow task creation when task content/data is exactly the defaults provided by the Form used to create the task". Basically: You were supposed to fill in some stuff but you did not when creating your task.