Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (63 w, 4 d)
Availability
Available

Recent Activity

Today

aklapper added a comment to T15048: Allow awarding Tokens to individual Comments.

@20after4: Willing to share some code at some point that folks can poke or play with? :) TIA!

Sun, May 19, 19:54 · Comments
aklapper awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Sun, May 19, 19:46 · Comments
aklapper closed T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sun, May 19, 11:10 · PHP 8 support
aklapper closed T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0 as Resolved by committing rPa579a974ebfe: PHPMailer: Remove use of each() function removed in PHP 8.0.
Sun, May 19, 11:10 · PHP 8 support
aklapper closed D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
Sun, May 19, 11:10
aklapper committed rPa579a974ebfe: PHPMailer: Remove use of each() function removed in PHP 8.0.
PHPMailer: Remove use of each() function removed in PHP 8.0
Sun, May 19, 11:10
aklapper updated the test plan for D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
Sun, May 19, 10:37
aklapper closed D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Sun, May 19, 08:28
aklapper committed rARC3cb117684f4e: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath
Sun, May 19, 08:28
aklapper closed D25663: PHPMailer: Remove check for non-existing get_magic_quotes().
Sun, May 19, 08:20
aklapper committed rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes().
PHPMailer: Remove check for non-existing get_magic_quotes()
Sun, May 19, 08:20
aklapper retitled D25663: PHPMailer: Remove check for non-existing get_magic_quotes() from PHPMailer: Remove check for non-existing `get_magic_quotes`
Sun, May 19, 08:19

Yesterday

aklapper updated the summary of D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Sat, May 18, 23:24
aklapper updated the diff for D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Valerio may have a point here :D

Sat, May 18, 23:23
aklapper requested review of D25663: PHPMailer: Remove check for non-existing get_magic_quotes().
Sat, May 18, 23:12
aklapper created T15836: ArcanistHardpointTask calls non-existent constructor for ArcanistHardpointFutureList.
Sat, May 18, 22:37
aklapper updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().
Sat, May 18, 22:25 · PHP 8 support
aklapper created T15835: Misc "Return type is not covariant" errors for method Iterator::key().
Sat, May 18, 22:20 · PHP 8 support
aklapper closed D25650: Correct PHPDoc or add default return for numerous methods.
Sat, May 18, 19:54
aklapper committed rPc1a8b83bd7ea: Correct PHPDoc or add default return for numerous methods.
Correct PHPDoc or add default return for numerous methods
Sat, May 18, 19:54
valerio.bozzolan awarded D25662: MimeMailParser: Remove an unused variable a Love token.
Sat, May 18, 19:50
aklapper abandoned D25662: MimeMailParser: Remove an unused variable.

I'm stupid and should have really checked the commit history first. Sorry!

Sat, May 18, 19:49
aklapper closed D25651: Fix typo creating QRbitstream().
Sat, May 18, 19:45
aklapper committed rP23a3f59be227: Fix typo creating QRbitstream().
Fix typo creating QRbitstream()
Sat, May 18, 19:45
aklapper added a comment to D25651: Fix typo creating QRbitstream().

Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)

Sat, May 18, 19:43
aklapper closed D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.
Sat, May 18, 19:41
aklapper committed rP8c8211787894: Fix PonderQuestionCreateMailReceiver accessing non-existing….
Fix PonderQuestionCreateMailReceiver accessing non-existing…
Sat, May 18, 19:41
aklapper updated the test plan for D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.
Sat, May 18, 19:39
aklapper closed D25640: Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php.
Sat, May 18, 19:39
aklapper committed rARC5477568274e3: Correct call to non-existing Filesystem::removePath() in….
Correct call to non-existing Filesystem::removePath() in…
Sat, May 18, 19:39
aklapper requested review of D25662: MimeMailParser: Remove an unused variable.
Sat, May 18, 07:41
aklapper added a comment to D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.

Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.

Sat, May 18, 06:44
aklapper added inline comments to D25661: PHPMailer: Remove a check for PHP 5.0.
Sat, May 18, 06:28
aklapper closed D25661: PHPMailer: Remove a check for PHP 5.0.
Sat, May 18, 00:00
aklapper committed rPa6499aee0ef4: PHPMailer: Remove a check for PHP 5.0.
PHPMailer: Remove a check for PHP 5.0
Sat, May 18, 00:00

Fri, May 17

aklapper updated the diff for D25661: PHPMailer: Remove a check for PHP 5.0.

Indentation is awesome

Fri, May 17, 14:21
aklapper requested review of D25661: PHPMailer: Remove a check for PHP 5.0.
Fri, May 17, 14:18
aklapper requested review of D25660: PHPMailer: Set defaults for required parameters followed by required parameters in Authorise() method signature.
Fri, May 17, 14:14
aklapper added a revision to T15834: Parameter order of Authorise() signature in phpmailer/class.pop3.php is deprecated since PHP 8.0: D25660: PHPMailer: Set defaults for required parameters followed by required parameters in Authorise() method signature.
Fri, May 17, 14:14 · PHP 8 support
aklapper requested review of D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
Fri, May 17, 13:56
aklapper added a revision to T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0: D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
Fri, May 17, 13:56 · PHP 8 support
aklapper requested review of D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.
Fri, May 17, 13:13
aklapper created T15834: Parameter order of Authorise() signature in phpmailer/class.pop3.php is deprecated since PHP 8.0.
Fri, May 17, 10:10 · PHP 8 support
aklapper updated the task description for T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0.
Fri, May 17, 10:05 · PHP 8 support
aklapper created T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0.
Fri, May 17, 10:00 · PHP 8 support
aklapper requested review of D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Fri, May 17, 09:47
aklapper requested review of D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.
Fri, May 17, 09:21
aklapper requested review of D25655: Fix call to non-existing newWorkCommands() in NuanceItemType.
Fri, May 17, 09:09
aklapper requested review of D25654: Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver.
Fri, May 17, 08:58
aklapper requested review of D25653: Fix call to non-existing getDisplayName() in DiffusionRepositoryClusterEngine.php.
Fri, May 17, 08:28
aklapper closed T15799: Reports tooltip hardcodes Maniphest Priority field names as Resolved by committing rPe6925c83c187: Do not hardcode default Priority names in Project Reports tooltip.
Fri, May 17, 07:16
aklapper closed D25602: Do not hardcode default Priority names in Project Reports tooltip.
Fri, May 17, 07:16
aklapper committed rPe6925c83c187: Do not hardcode default Priority names in Project Reports tooltip.
Do not hardcode default Priority names in Project Reports tooltip
Fri, May 17, 07:16

Thu, May 16

aklapper updated the diff for D25602: Do not hardcode default Priority names in Project Reports tooltip.

Improvicate some things that valerio mentioned. (I prefer "Average" to "Normal" though; I consider "normal" a problematic term in this context.)

Thu, May 16, 18:47
aklapper requested review of D25652: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine.
Thu, May 16, 15:29
aklapper added a comment to D25651: Fix typo creating QRbitstream().

It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.

Thu, May 16, 15:16
aklapper requested review of D25651: Fix typo creating QRbitstream().
Thu, May 16, 15:15
aklapper requested review of D25650: Correct PHPDoc or add default return for numerous methods.
Thu, May 16, 14:42
valerio.bozzolan awarded D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment a Love token.
Thu, May 16, 12:18
aklapper updated the diff for D25642: Initialize $cache_key variable in CelerityResourceController.php.

I felt it's not necessarily needed but it cannot hurt either. :)

Thu, May 16, 11:52
aklapper requested review of D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.
Thu, May 16, 11:28
aklapper requested review of D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
Thu, May 16, 11:16
aklapper requested review of D25647: Fix call to non-existing newIcons() in PhabricatorIconSet.
Thu, May 16, 11:03
aklapper requested review of D25646: Correct rendering of workboard column move feed stories when a single transaction performs moves on multiple boards.
Thu, May 16, 10:55
aklapper requested review of D25645: Fix call to non-existing Filesystem::digestForIndex() in PhabricatorUserCache.
Thu, May 16, 10:42
aklapper requested review of D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment.
Thu, May 16, 10:25
aklapper requested review of D25643: Fix call to non-existing newError() in PhabricatorEditorExtension.
Thu, May 16, 10:07
aklapper requested review of D25642: Initialize $cache_key variable in CelerityResourceController.php.
Thu, May 16, 09:46
aklapper requested review of D25641: Correct call to non-existing PhutilFileLockException in support/unit/lock.php.
Thu, May 16, 08:53
aklapper requested review of D25640: Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php.
Thu, May 16, 08:45
aklapper closed D25634: Remove deprecated buildStandardPage* method calls.
Thu, May 16, 06:39
aklapper committed rPd5295da072ae: Remove deprecated buildStandardPage* method calls.
Remove deprecated buildStandardPage* method calls
Thu, May 16, 06:39

Wed, May 15

aklapper closed T15826: PHP 8.1 "strlen(null)" exception rendering image file without $encode_setting, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Wed, May 15, 15:31 · PHP 8 support
aklapper closed T15826: PHP 8.1 "strlen(null)" exception rendering image file without $encode_setting as Resolved by committing rP50d0bbe8ff68: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.
Wed, May 15, 15:31 · PHP 8 support
aklapper closed D25638: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.
Wed, May 15, 15:31
aklapper committed rP50d0bbe8ff68: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.
Fix PHP 8.1 "strlen(null)" exception rendering files/documents
Wed, May 15, 15:31
aklapper closed T15832: PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Wed, May 15, 12:45 · PHP 8 support
aklapper closed T15832: PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php as Resolved by committing rP464a0aedc45b: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.
Wed, May 15, 12:45 · PHP 8 support
aklapper closed D25639: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.
Wed, May 15, 12:45
aklapper committed rP464a0aedc45b: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.
Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php
Wed, May 15, 12:45
aklapper requested review of D25639: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.
Wed, May 15, 12:33
aklapper added a revision to T15832: PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php: D25639: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.
Wed, May 15, 12:33 · PHP 8 support
aklapper created T15832: PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php.
Wed, May 15, 12:32 · PHP 8 support
valerio.bozzolan awarded T15831: Long search query can trigger raw "Too many tables; MariaDB can only use 61 tables in a join" a The World Burns token.
Wed, May 15, 11:59
aklapper created T15831: Long search query can trigger raw "Too many tables; MariaDB can only use 61 tables in a join".
Wed, May 15, 10:10

Mon, May 13

aklapper updated the diff for D25636: Fix exception awarding empty badge to user.

Remove variable definition now unneeded outside of the if clause

Mon, May 13, 18:50
aklapper updated the diff for D25636: Fix exception awarding empty badge to user.

Here's a revision which does not throw a red box via ->setFormErrors() at the user but at least it is displaying the Required text and turning it into bold red after clicking Award without having defined a recipient. So the line $errors[] = pht('Badge name is required.'); is currently never ever shown.

Mon, May 13, 18:43
aklapper added a comment to D25636: Fix exception awarding empty badge to user.

Thanks for the hints how to improve this! Appreciated.

Mon, May 13, 18:41
aklapper created T15827: Possible to award a badge without selecting a recipient.
Mon, May 13, 18:41
aklapper requested review of D25638: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.
Mon, May 13, 17:49
aklapper added a revision to T15826: PHP 8.1 "strlen(null)" exception rendering image file without $encode_setting: D25638: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.
Mon, May 13, 17:49 · PHP 8 support
aklapper closed D25637: Run ./bin/celerity map after previous commit.
Mon, May 13, 17:00
aklapper committed rP8a3b70aa7d4c: Run ./bin/celerity map after previous commit.
Run ./bin/celerity map after previous commit
Mon, May 13, 17:00
aklapper added a comment to T15819: Facts: Burndown Charts should render YYYY-MM-DD with eight digits.

That was a merged JS change so I should have also run ./bin/celerity map. Sorry. Followup patch in https://we.phorge.it/D25637

Mon, May 13, 16:04
aklapper requested review of D25637: Run ./bin/celerity map after previous commit.
Mon, May 13, 16:03
aklapper created T15826: PHP 8.1 "strlen(null)" exception rendering image file without $encode_setting.
Mon, May 13, 15:59 · PHP 8 support
aklapper awarded T15800: Comment templates to reuse a Love token.
Mon, May 13, 11:42 · Feature Requests, Phorge

Sun, May 12

aklapper added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

I don't believe in playing whack-a-mole on "could this be a password" but a use case I've been recently thinking of is "Do not allow task creation when task content/data is exactly the defaults provided by the Form used to create the task". Basically: You were supposed to fill in some stuff but you did not when creating your task.

Sun, May 12, 13:03 · Herald, Maniphest, User-valerio.bozzolan
aklapper closed T15819: Facts: Burndown Charts should render YYYY-MM-DD with eight digits as Resolved by committing rP67b7181f5226: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Sun, May 12, 08:19
aklapper closed D25630: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Sun, May 12, 08:19