Paths

Table of Contentst

Differential D25638

Fix PHP 8.1 "strlen(null)" exception rendering files/documents
ClosedPublic
Actions

Authored by aklapper on Mon, May 13, 17:49.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 31, 20:49

	Unknown Object (File)
	Thu, May 30, 22:21

	Unknown Object (File)
	Sat, May 25, 20:45

	Unknown Object (File)
	Wed, May 22, 23:45

	Unknown Object (File)
	Wed, May 22, 23:45

	Unknown Object (File)
	Wed, May 22, 22:38

	Unknown Object (File)
	Wed, May 22, 21:51

	Unknown Object (File)
	Tue, May 21, 16:41

View All 22 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15826: PHP 8.1 "strlen(null)" exception rendering image file without $encode_setting

Commits

rP50d0bbe8ff68: Fix PHP 8.1 "strlen(null)" exception rendering files/documents

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]

Closes T15826

Test Plan

Surf a Diffusion repository and play with View Options.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, May 13, 17:49

Owners added a reviewer: O1: Blessed Committers.Mon, May 13, 17:49

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, May 13, 17:49

aklapper requested review of this revision.Mon, May 13, 17:49

Harbormaster completed remote builds in B1254: Diff 1981.Mon, May 13, 17:49

yesyes

Thanks. Tested.

This revision is now accepted and ready to land.Wed, May 15, 12:48

Closed by commit rP50d0bbe8ff68: Fix PHP 8.1 "strlen(null)" exception rendering files/documents. · Explain WhyWed, May 15, 15:31

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP50d0bbe8ff68: Fix PHP 8.1 "strlen(null)" exception rendering files/documents.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

files/

document/

render/

PhabricatorDocumentRenderingEngine.php

4 lines

O1: Blessed Committers

Diff 1989

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...