Paths

Table of Contentst

Differential D25626

The feed "created this task" should be the first one
ClosedPublic
Actions

Authored by valerio.bozzolan on Wed, May 8, 10:08.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15816: The feed "created this task" should be the first one

Commits

rPf4d9d6920bcd: The feed "created this task" should be the first one

Summary

Create a Maniphest task, Resolved, High priority.

Before this change, this was the feed in the object page:

a.lincoln closed this task as Resolved.
a.lincoln triaged this task as High priority.
a.lincoln created this task.

After this change, this is the feed:

a.lincoln created this task.
a.lincoln closed this task as Resolved.
a.lincoln triaged this task as High priority.

This also improves the situation in the /feed/ page. So you see the creation now.

Ref T15816

Test Plan

Create an object in any mentioned application below, setting all fields.

Then, check the history of the object itself. Check also the /feed/ page.
Check that the creation action is now listed first.

This change improves the situation in:

Maniphest
Phriction

This change has no impact on these that seem already OK:

Calendar
Dashboard
Dashboard Panel
Diffusion
Macro
Paste
Ponder
Project
Pholio

This change has no impact on these that seem still in the wrong order:

Differential

The above situation in Differential is noted, but it's unrelated,
since it has a different legacy structure and it deserves more triaging.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Wed, May 8, 10:08

Owners added a reviewer: O1: Blessed Committers.Wed, May 8, 10:08

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptWed, May 8, 10:08

valerio.bozzolan requested review of this revision.Wed, May 8, 10:08

Harbormaster completed remote builds in B1235: Diff 1951.Wed, May 8, 10:08

I can confirm this works as expected for the task view itself in e.g. http://phorge.localhost/T1168 . This seems to also fix http://phorge.localhost/feed/ so it does not only show me about setting high priority on a new task, but instead shows that the task was created? That would be a nice side effect too IMO.

I'm a little bit wondering if you could elaborate how you came to the value 140? It might make total sense, just wondering what you compared with.

In D25626#17531, @aklapper wrote:

This seems to also fix http://phorge.localhost/feed/ so it does not only show me about setting high priority on a new task, but instead shows that the task was created? That would be a nice side effect too IMO.

Uh! I can confirm that. I'm adding that in commit message.

I'm a little bit wondering if you could elaborate how you came to the value 140? It might make total sense, just wondering what you compared with.

Thanks. For details about that 140, see comments in line 34 and 35, and super-nice details in T15816

valerio.bozzolan edited the summary of this revision. (Show Details)Wed, May 8, 12:41

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan awarded a token.Thu, May 9, 19:51

I currently cannot think of other potential side effects (mail notifications about task creation seem to have had a [Created] prefix taking priority over other actions for years, and web notifications in the top bar also still behave as before), so I'll give my +1

This revision is now accepted and ready to land.Fri, May 10, 09:05

Closed by commit rPf4d9d6920bcd: The feed "created this task" should be the first one. · Explain WhySat, May 18, 08:05

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rPf4d9d6920bcd: The feed "created this task" should be the first one.

valerio.bozzolan mentioned this in Next Up.Sat, May 18, 08:15

mainframe98 awarded a token.Sat, May 18, 08:54