The scenario in which this index would be needed is far from being normal. The patch D26027 that would benefit for it, is able to avoid that query in 99% of cases (it only needs such query when you want to destroy a profile picture, AND that picture was manually un-attached... why was it manually un-attached? by a spam click? by a faulty mouse?). So, the normal scenario is too small and unclear to justify a new index.

Again, expanding a PhabricatorFileAttachment to support a destruction engine to post-pone its destruction does NOT work as intended (as it's still destroyed very after the file) since the destroyObjectPermanently() is always supposed to be executed BEFORE the extensions.

OK I've explored the proposal n. 1 about expanding PhabricatorFileAttachment to support PhabricatorDestructibleInterface, but I'm just moving the problem there. The attachment is still immediately nuclearized BEFORE the extensions can do things.

When you destroy a PhabricatorFile, it seems this happens:

It seems it's necessary to be able to "get the user from a profile picture". This is not easy, since the user seems not mentioned in any obvious way from the file object, as already stated in T15407.

Plus, making the file editable by the author is the cure of T15814, so, moving that as parent task.

If we allow authors to destroy their images, we should also avoid 404 errors on them. So, the new subtask T16074.

In T15998#21086, @Cigaryno wrote:

Did anyone think of showing two separate queries on Tasks

What is Tasks? Could you share an URI? By default http://phorge.localhost/maniphest/ already offers Assigned, Authored, etc. saved queries in the sidebar.

As a general rule, I prefer the have the abstractions as much as possible, to allow extensions to do things.
In this case, an abstraction would also make this feature easier to enable/disable, which I think is desired.

Chris has asked me to pick this up as he'd like to see this implemented.

This is a great proposal. Did anyone think of showing two separate queries on Tasks: Assigned and Authored. In my opinion, it just makes it harder to scroll down to authored tasks which is why it makes more sense to have separate Assigned Tasks and Authored Tasks views on the profile menu.

I proposed two related patches in D25683 and D25685, both of them obsoleted by: D25687.

After a small database inspection, it seems that uploading the picture causes:

(Oh sorry avivey, I have not noticed your priority action - I agree)

I do not (yet?) understand the use case of this task.

Indeed reported from a Wikimedia user about Wikimedia Phabricator.

In T15671#14420, @avivey wrote:

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Maybe this can be done as an extension:

• Abstract the "profile picture provider"
• Allow an extension to write a Gravatar one

There are currently 2-3 sources, so maybe there is some abstraction:

• pokemon-style silhouette
• Character with background (generated from username)
• Upload Picture