In D26037#27779, @aklapper wrote:

Yes to the idea however a related elephant in the room (IMHO) are those non-standard types like list or map or wild being replaced, no clue if that has any effects on...something™ (Diviner docs? Code?) as I haven't managed to understand the consequences of code in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilTypeSpec.php yet. (Technically speaking map and list seem to be just arrays, indeed.)

Yeah, I've been wanting to put up a codemod diffs that get rid of all the custom types: wild, dict, dictionary, map, etc. None of these are understood by modern phpdoc tooling and while we could configure phpstan to understand them, it's probably easiest to just use whatever everyone else is using, especially because some editor extensions don't have a way to add custom types so we'd be leaving potential contributors at a disadvantage if they don't have phpstan.

Update signature to protected and add missing argument everywhere.

In D26040#27816, @aklapper wrote:

Running phpstan analyse, [...] Method ArcanistWorkflow::runWorkflow() invoked with 1 parameter, 0 required, both in src/workflow/ArcanistWorkflow.php:227. That looks like an improvement indeed.

In D26040#27819, @valerio.bozzolan wrote:

In D26040#27816, @aklapper wrote:

Keeping it protected will throw Protected method PhageExecWorkflow::runWorkflow() overriding public method ArcanistWorkflow::runWorkflow() should also be public.

Exactly what I mean: this patch introduced a public method, but what about just introducing a protected method? and rollback src/phage/workflow/PhageExecWorkflow.php

Get rid of coverage errors :)

This isn't important, it just seems like this is a nice in-context place to leave this information :)

Use R[] because the keys may not be sequential.

Hmm.. clearly I need to set xdebug.mode correctly, but I'm not sure why it wasn't. It's been fine before.

I'd be very much in favor and I'd be happy to contribute changes for this. I've added type hints in my local fork to assist in development. Especially for core utility functions like idx and id which otherwise completely hide type information.

Tools make no mistakes.

Remove first person voice in a few areas. And a bit of swearing that slipped through from my notes.

@valerio.bozzolan looks to not change behavior in mercurial at all :) I'm not in Trusted Contributors so I can't accept.

A comment in two parts:
First and most relevant to this task: It certainly would be nice to get some of this into documentation! It took me quite awhile to figure this out when doing my own extension development.