Page MenuHomePhorge
Feed Advanced Search

May 17 2023

arnold closed T15400: Unable to arc-diff against this install as Resolved.

Issue on my end, will try to get the Mysql credentials set up for running tests

May 17 2023, 15:19 · phorge.it install
arnold added a comment to T15400: Unable to arc-diff against this install.

Ah! That makes sense!

May 17 2023, 15:18 · phorge.it install
arnold added a comment to T15400: Unable to arc-diff against this install.

(Unless there's some PHP 8.2 bug in my arc invocation... )

May 17 2023, 15:07 · phorge.it install
arnold added a comment to T15400: Unable to arc-diff against this install.

Pretty sure, here's the full --trace output, you can see it's trying to talk to we.phorge.it (also, I see we.phorge.it in my ~/.arcrc)

May 17 2023, 15:04 · phorge.it install

May 15 2023

arnold created T15400: Unable to arc-diff against this install.
May 15 2023, 19:47 · phorge.it install
arnold created T15399: PHP 8.2 strlen() null issues when arc-diffing.
May 15 2023, 19:36 · Clarification Needed, PHP 8 support

May 12 2023

arnold accepted D25220: PhabricatorModularTransactionType: fix regression.

lgtm

May 12 2023, 17:29
arnold added a comment to T15385: Fix Almanac page /almanac/interface/edit/1/.

@valerio.bozzolan I can verify that the proposed patch works for me

May 12 2023, 16:47 · Bug Reports, PHP 8 support
arnold added inline comments to D25202: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for Packages' Create Package and Fund's Create Initiative.
May 12 2023, 16:43
arnold added a comment to D25202: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for Packages' Create Package and Fund's Create Initiative.

When editing almanac hosts, I get this: (url /almanac/interface/edit/1/)

May 12 2023, 15:39
arnold added a comment to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.

This is a good example of why fixing each case individually might be a bad idea, this fix was from D25202. It appears the old strlen allowed for integers too...

May 12 2023, 15:38 · PHP 8 support
arnold added a comment to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.

@valerio.bozzolan Here's a small sampling of all the errors that I encountered (I fixed each of them and got to the next one): https://we.phorge.it/P10

May 12 2023, 15:10 · PHP 8 support
arnold created P10 (An Untitled Masterwork).
May 12 2023, 15:09
arnold added a comment to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.

@valerio.bozzolan You know, I went on a spree fixing this in my local checkout. But it's super spread out all throughout the repo. The current master is broken even when I just view a revision. Then there are issues that show up in the SSH auth code when trying to push where the stack trace gets hidden (and it'll say something about ENORMOUS CHANGES, but that's a lie)

May 12 2023, 15:04 · PHP 8 support
arnold updated arnold.
May 12 2023, 14:56
arnold added a comment to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.

Re: all the null errors.

May 12 2023, 14:50 · PHP 8 support