Details

Reviewers

avivey
Cigaryno

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'

Commits

rP8ffa6044626d: Diviner: mention how to flag Arcanist and Phorge as "safe" git repos

Summary

This tip is useful if you are affected by the following error in git or similar:

fatal: detected dubious ownership in repository at '/var/www/phorge'

Just follow the new tip from Diviner to fix at system level.

Ref T15282

Test Plan

see if you like the documentation tip
try to execute the command, and verify that your computer does not explode
eventually visit the /config/ page with and without that change (with and without a /etc/gitconfig)

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25236

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 547
Build 547: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.May 23 2023, 09:35

Owners added a reviewer: O1: Blessed Committers.May 23 2023, 09:35

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMay 23 2023, 09:35

valerio.bozzolan requested review of this revision.May 23 2023, 09:35

Harbormaster completed remote builds in B441: Diff 783.May 23 2023, 09:36

valerio.bozzolan retitled this revision from Diviner: mention how to flag Arcanist and Phorge as "safe" git repos This tip is useful if you are affected by the following error in git or similar: fatal: detected dubious ownership in repository at '/var/www/phorge' Just follow the new... to Diviner: mention how to flag Arcanist and Phorge as "safe" git repos.May 23 2023, 09:36

valerio.bozzolan edited the summary of this revision. (Show Details)

add more useful text

Harbormaster completed remote builds in B442: Diff 784.May 23 2023, 09:42

fix linter

Harbormaster completed remote builds in B443: Diff 785.May 23 2023, 09:42

valerio.bozzolan mentioned this in T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'.May 23 2023, 09:51

valerio.bozzolan mentioned this in Q32: ExecFuture / Diffusion returns "fatal: detected dubious ownership in repository at ..." (Answer 28).May 24 2023, 08:03

valerio.bozzolan mentioned this in Q32: ExecFuture / Diffusion returns "fatal: detected dubious ownership in repository at ..." (Answer 41).May 24 2023, 08:09

valerio.bozzolan edited the test plan for this revision. (Show Details)May 25 2023, 12:02

valerio.bozzolan mentioned this in D25149: Config page: add $HOME to allow a gitconfig and help on "dubious ownership".Jun 11 2023, 07:49

I'm ok with this change, under the T15457: Update installation docs to talk about linux users umbrella.

@speck?

avivey added inline comments.Jun 11 2023, 08:34

src/docs/user/installation_guide.diviner
138	I don't think "unprivileged" is exactly correct - IIUC, the rule is "only the owner of the directory", with "owner" being a little more lenient then normal. Not sure if it's important for this page. But mentioning the explicit error message would make this page pop up in likely Google search.