Differential D25238

Correct spelling mistakes
ClosedPublic
Actions

Authored by Edward on May 23 2023, 17:32.

Tags

None

Referenced Files

None

Subscribers

valerio.bozzolan

Tokens

"Like" token, awarded by valerio.bozzolan.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP4862eada5cd0: Correct spelling mistakes

Test Plan

Only changes to spelling.

Diff Detail

Repository

Branch

arcpatch-D25238

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/aphront/response/AphrontResponse.php:330	XHP16	TODO Comment
Advice	src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php:520	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 446
Build 446: arc lint + arc unit

Event Timeline

Edward created this revision.May 23 2023, 17:32

Owners added a reviewer: O1: Blessed Committers.May 23 2023, 17:32

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 23 2023, 17:32

Edward requested review of this revision.May 23 2023, 17:32

valerio.bozzolan awarded a token.May 23 2023, 18:04

arc lint

Harbormaster completed remote builds in B446: Diff 794.May 23 2023, 18:06

I'm a simple person. I see changes in Diviner, changes in comments, and something that 99.999999999% will not cause a nuclear implosion, and I put +1.

Thank you so much! :)

lgtm

This revision is now accepted and ready to land.May 23 2023, 18:07

Thanks again for this patch!

If you want to try a new hallucinatory thing, try this to "Land" this change:

../arcanist/bin/arc patch D25238
../arcanist/bin/arc land

The tradition wants that the author lands.

If you don't want to try, feel free to just say "Naaah whatever, land this for me". No problem! :)

In D25238#7248, @valerio.bozzolan wrote:
Thanks again for this patch!

If you want to try a new hallucinatory thing, try this to "Land" this change:
../arcanist/bin/arc patch D25238
../arcanist/bin/arc land
The tradition wants that the author lands.

If you don't want to try, feel free to just say "Naaah whatever, land this for me". No problem! :)

Hi @Edward, feel free to say "Naah whatever" :)

Closed by commit rP4862eada5cd0: Correct spelling mistakes. · Explain WhyMay 27 2023, 21:19

This revision was automatically updated to reflect the committed changes.

Edward added a commit: rP4862eada5cd0: Correct spelling mistakes.

Revision Contents
Changeset List

Path

Size

Packages

src/

aphront/

response/

AphrontResponse.php

2 lines

O1: Blessed Committers

applications/

conduit/

controller/

PhabricatorConduitAPIController.php

2 lines

O1: Blessed Committers

config/

check/

PhabricatorDatabaseSetupCheck.php

2 lines

O1: Blessed Committers

option/

PhabricatorMetaMTAConfigOptions.php

2 lines

O1: Blessed Committers

harbormaster/

xaction/

build/

HarbormasterBuildMessageResumeTransaction.php

2 lines

O1: Blessed Committers

repository/

management/

PhabricatorRepositoryManagementMaintenanceWorkflow.php

2 lines

O1: Blessed Committers

worker/

__tests__/

PhabricatorChangeParserTestCase.php

2 lines

O1: Blessed Committers

search/

compiler/

PhutilSearchQueryCompiler.php

2 lines

O1: Blessed Committers

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

2 lines

O1: Blessed Committers

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

O1: Blessed Committers

docs/

contributor/

database.diviner

2 lines

O1: Blessed Committers

general_coding_standards.diviner

2 lines

O1: Blessed Committers

user/

configuration/

configuring_inbound_email.diviner

2 lines

O1: Blessed Committers

userguide/

multi_factor_auth.diviner

2 lines

O1: Blessed Committers

webhooks.diviner

2 lines

O1: Blessed Committers

infrastructure/

customfield/

field/

PhabricatorCustomField.php

2 lines

O1: Blessed Committers

markup/

blockrule/

PhutilRemarkupLiteralBlockRule.php

2 lines

O1: Blessed Committers

syntax/

highlighter/

xhpast/

PhutilXHPASTSyntaxHighlighterFuture.php

2 lines

O1: Blessed Committers

parser/

PhutilPygmentizeParser.php

2 lines

O1: Blessed Committers

view/

control/

AphrontTableView.php

2 lines

O1: Blessed Committers

Diff 794

src/aphront/response/AphrontResponse.php

Loading...

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...

src/applications/config/check/PhabricatorDatabaseSetupCheck.php

Loading...

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

Loading...

src/applications/harbormaster/xaction/build/HarbormasterBuildMessageResumeTransaction.php

Loading...

src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php

Loading...

src/applications/repository/worker/tests/PhabricatorChangeParserTestCase.php

Loading...

src/applications/search/compiler/PhutilSearchQueryCompiler.php

Loading...

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/docs/contributor/database.diviner

Loading...

src/docs/contributor/general_coding_standards.diviner

Loading...

src/docs/user/configuration/configuring_inbound_email.diviner

Loading...

src/docs/user/userguide/multi_factor_auth.diviner

Loading...

src/docs/user/userguide/webhooks.diviner

Loading...

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...

src/infrastructure/markup/blockrule/PhutilRemarkupLiteralBlockRule.php

Loading...

src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

Loading...

src/infrastructure/parser/PhutilPygmentizeParser.php

Loading...

src/view/control/AphrontTableView.php

Loading...