Fix PHP 8.1 "strlen(null)" exception which blocks Working Copy blueprint creation in Drydock
ClosedPublic
Actions

Authored by aklapper on May 21 2023, 08:25.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15409: PHP 8.1 "strlen(null)" exception blocks creating Working Copy blueprint in Drydock

Commits

rP19d9da7feae9: Fix PHP 8.1 "strlen(null)" exception which blocks Working Copy blueprint…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. So, we adopt an explicit cast to string
in order to answer the question "Is this a non-empty string?" without relying on implicit
cast and deprecated things.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_string_cast() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15409

Test Plan

Applied this change and afterwards, selecting "Working Copy" on /drydock/blueprint/edit/form/default/ does not show a RuntimeException on strlen() anymore. Instead, it shows a PhutilAggregateException covered in T15408.

Try also creating an integer "Custom Field" in some applications like Maniphest (maniphest.custom-field-definitions)
or in the People component (user.custom-field-definitions) etc., populating the related forms with your usual fuzzy tests.

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25235

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 434
Build 434: arc lint + arc unit

Event Timeline

aklapper created this revision.May 21 2023, 08:25

Owners added a reviewer: O1: Blessed Committers.May 21 2023, 08:26

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 21 2023, 08:26

aklapper requested review of this revision.May 21 2023, 08:26

Harbormaster completed remote builds in B433: Diff 775.May 21 2023, 08:26

Thanks for this troubleshooting and this patch (again) :)

Warning: I was able to reproduce the usual nuclear implosion. I tried to populate a custom integer field from a Maniphest Task from a normal form. I tried that just because the name of this class is about FieldInt so it was a bit suspicious.

Hoping to be useful I will amend our usual replacement

replace phutil_nonempty_string() with just an explicit cast to string to answer the question "is this string non empty?"
so this works with integers as well, without crashes.

Harbormaster completed remote builds in B434: Diff 776.May 21 2023, 08:51

Tested, no nuclear implosions

sgtm