Page MenuHomePhorge
Differential D25233

Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces
ClosedPublic
Actions

Authored by aklapper on May 20 2023, 12:50.
Tags
None
Referenced Files
F2174798: D25233.id760.diff
Thu, May 2, 11:41
Unknown Object (File)
Thu, May 2, 10:00
Unknown Object (File)
Tue, Apr 30, 06:19
Unknown Object (File)
Tue, Apr 30, 06:19
Unknown Object (File)
Mon, Apr 29, 19:52
Unknown Object (File)
Thu, Apr 25, 14:25
Unknown Object (File)
Thu, Apr 25, 14:25
Unknown Object (File)
Thu, Apr 25, 13:50
View All 85 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15406: PHP Fatal error in Figlet due to use of curly braces
Commits
rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces
Summary

Replace curly with square brackets when accessing an array value. See
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
https://wiki.php.net/rfc/deprecate_curly_braces_array_access#wasn_t_the_curly_brace_syntax_deprecated_once_before

Closes T15406

Test Plan

Fixed these two lines; afterwards Figlet rendered in task comment preview. Example figlet:

figlet {{{ stuff }}}

Diff Detail

Repository
rP Phorge
Branch
T15406 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 424
Build 424: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
externals/
pear-figlet/
Text/
4 linesO1: Blessed Committers

Diff 760

View Options

externals/pear-figlet/Text/Figlet.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0