Differential D25233

Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces
ClosedPublic
Actions

Authored by aklapper on May 20 2023, 12:50.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15406: PHP Fatal error in Figlet due to use of curly braces

Commits

rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces

Summary

Replace curly with square brackets when accessing an array value. See
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
https://wiki.php.net/rfc/deprecate_curly_braces_array_access#wasn_t_the_curly_brace_syntax_deprecated_once_before

Closes T15406

Test Plan

Fixed these two lines; afterwards Figlet rendered in task comment preview. Example figlet:

figlet {{{ stuff }}}

Diff Detail

Repository

rP Phorge

Branch

T15406 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 424
Build 424: arc lint + arc unit

Event Timeline

aklapper created this revision.May 20 2023, 12:50

Owners added a reviewer: O1: Blessed Committers.May 20 2023, 12:50

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 20 2023, 12:50

aklapper requested review of this revision.May 20 2023, 12:50

Harbormaster completed remote builds in B424: Diff 760.May 20 2023, 12:50

Thanks again for this patch

Tested this locally with various:

figlet {{{ stuff }}}

No nuclear implosions

sgtm

This revision is now accepted and ready to land.May 20 2023, 15:15

valerio.bozzolan edited the test plan for this revision. (Show Details)May 20 2023, 15:16

Closed by commit rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces. · Explain WhyMay 20 2023, 15:43

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 21 2023, 11:17

Revision Contents
Changeset List

Path

Size

Packages

externals/

pear-figlet/

Text/

Figlet.php

4 lines

O1: Blessed Committers

Diff 760

View Options

externals/pear-figlet/Text/Figlet.php

Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly bracesClosedPublicActions