Paths

Table of Contentst

Differential D25226

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures
ClosedPublic
Actions

Authored by aklapper on May 13 2023, 11:04.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 30, 12:13

	Unknown Object (File)
	Mon, Apr 29, 19:51

	Unknown Object (File)
	Thu, Apr 25, 14:26

	Unknown Object (File)
	Thu, Apr 25, 14:26

	Unknown Object (File)
	Thu, Apr 25, 13:50

	Unknown Object (File)
	Thu, Apr 25, 13:40

	Unknown Object (File)
	Mon, Apr 22, 08:22

	Unknown Object (File)
	Mon, Apr 22, 07:56

View All 80 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15395: PHP 8.1 "strlen(null)" exceptions block rendering Legalpad signatures

Commits

rP912a933b0214: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15395

Test Plan

Applied these two changes; afterwards "All Signatures" page at /legalpad/signatures/1/ gets rendered in web browser.

Diff Detail

Repository

Branch

legalViewSigs (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 409
Build 409: arc lint + arc unit

Event Timeline

aklapper created this revision.May 13 2023, 11:04

Owners added a reviewer: O1: Blessed Committers.May 13 2023, 11:04

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 13 2023, 11:04

aklapper requested review of this revision.May 13 2023, 11:04

Harbormaster completed remote builds in B409: Diff 733.May 13 2023, 11:04

aklapper mentioned this in T15396: PHP 8.1 "strlen(null)" exception blocks rendering "Browse Dashboards" dialog.May 13 2023, 11:23

aklapper mentioned this in D25227: Fix PHP 8.1 "strlen(null)" exception which blocks rendering "Browse Dashboards" dialog.May 13 2023, 11:24

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

aklapper mentioned this in rP402a63c5de96: Fix PHP 8.1 "strlen(null)" exception which blocks rendering "Browse Dashboards"….May 19 2023, 10:00

Thanks for this patch (again!)

I tested this locally with fuzzy tests in the Name Contains and Email Contains input fields, without any nuclear implosion.

The function phutil_nonempty_string() will report any alien value that is not string or null, and I verified that this is OK here.

sgtm

This revision is now accepted and ready to land.May 19 2023, 10:45

Closed by commit rP912a933b0214: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures. · Explain WhyMay 19 2023, 15:02

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP912a933b0214: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

legalpad/

query/

LegalpadDocumentSignatureSearchEngine.php

4 lines

O1: Blessed Committers

Diff 733

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

Loading...