Fix PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider
ClosedPublic
Actions

Authored by aklapper on May 10 2023, 18:09.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15383: PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider

Commits

rP678c7a78be43: Fix PHP 8.1 "strlen(null)" exceptions setting up Username/Password…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15383

Test Plan

Applied these two changes; afterwards "Username/Password" page at /auth/config/view/1/ gets rendered in web browser.

Additional tests (you need D25231 to complete this test plan):

Create WordPress Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Twitter Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Amazon Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Asana Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Bitbucket Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Disqus Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Disqus Auth; Edit; Disable Enable (and Disable again to cleanup)
Create Facebook Auth; Edit; Disable Enable (and Disable again to cleanup)
Create GitHub Auth; Edit; Disable Enable (and Disable again to cleanup)
Create JIRA Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Google Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create LDAP Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Phorge Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Slack Auth; Edit; Disable; Enable (and Disable again to cleanup)
Create Twitch.tv Auth; Edit; Disable; Enable (and Disable again to cleanup)

Diff Detail

Repository

rP Phorge

Branch

setupAuthProv (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 393
Build 393: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	67 ms	PhabricatorAuthSSHKeyTestCase::testRevokeSSHKey EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	371 ms	PhabricatorAuthPasswordTestCase::testCompare 2 assertions passed.
	21 ms	PhabricatorAuthPasswordTestCase::testPasswordBlocklisting 15 assertions passed.
	1,718 ms	PhabricatorAuthPasswordTestCase::testPasswordEngine 20 assertions passed.
	323 ms	PhabricatorAuthPasswordTestCase::testPasswordUpgrade 9 assertions passed.
		View Full Test Results (1 Failed · 11 Passed)