Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled
ClosedPublic
Actions

Authored by aklapper on May 9 2023, 18:24.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15374: PHP 8.1 "strlen(null)" exceptions block rendering user page after creation with Welcome Email enabled

Commits

rPc86364c2aa6d: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15374

Test Plan

Applied these two changes, performed the user creation steps again, and afterwards the user page at /p/user5/ finally rendered in web browser.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 9 2023, 18:24

Owners added a reviewer: O1: Blessed Committers.May 9 2023, 18:24

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 9 2023, 18:24

aklapper requested review of this revision.May 9 2023, 18:24

Harbormaster completed remote builds in B385: Diff 702.May 9 2023, 18:24

aklapper mentioned this in T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.May 9 2023, 19:01

Thanks again

Tested locally creating an User, sending automatic welcome, sending default welcome, sending custom welcome, no implosions.

sgtm

src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php
121	✅ I verified the above line that seems to only receive strings or null. This is the welcome message wrote by the Administrator, in raw Remarkup string form. The function `phutil_nonempty_string()` will report any alien type, like objects, and that is OK here.
128	✅ I verified the above line that seems to only receive strings or null. This contains the default body that an Administrator can change for custom instructions. This is the welcome message wrote by the Administrator, in raw Remarkup string form. The function `phutil_nonempty_string()` will report any alien type, like objects, and that is OK here.
132–137	(:D)